-
Notifications
You must be signed in to change notification settings - Fork 195
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for CloudFormation intrinsic functions (Go->YAML/JSON) #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… was preventing the generated cloudformation from having a Properties field
… was preventing the generated cloudformation from having a Properties field
…unmarshal to objects in post-processing. This also has the benefit of easily supporting all intrinsic functions
@PaulMaddox thanks for looking into this, I think it's definitely worse exploring! I do see two additional limitations:
Both of the above are actually important for |
Parsing a template with intrinsics (inc. nested) into a Go struct will work. This should work already. Nesting intrinsics should work when going from Go->YAML too (I'll add a test case for this). |
PaulMaddox
changed the title
POC: Support for CloudFormation references
POC: Support for CloudFormation intrinsic functions when doing Go->YAML/JSON
Sep 13, 2018
PaulMaddox
changed the title
POC: Support for CloudFormation intrinsic functions when doing Go->YAML/JSON
Support for CloudFormation intrinsic functions for Go->YAML/JSON
Sep 13, 2018
PaulMaddox
changed the title
Support for CloudFormation intrinsic functions for Go->YAML/JSON
Support for CloudFormation intrinsic functions (Go->YAML/JSON)
Sep 13, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An alternative (to #103) implementation of CloudFormation references (!Ref).
It works by adding a few simple methods in the cloudformation package for inserting intrinsic functions, such as !Ref and !GetAtt. For example:
The following list of functions are available to use when creating templates:
cloudformation.Ref(logicalName string)
cloudformation.GetAtt(logicalName string, attribute string)
cloudformation.ImportValue(name string)
cloudformation.Base64(input string)
cloudformation.CIDR(ipBlock, count, cidrBits string)
cloudformation.FindInMap(mapName, topLevelKey, secondLevelKey string)
cloudformation.GetAZs(region string)
cloudformation.Join(delimiter string, values []string)
cloudformation.Select(index string, list []string)
cloudformation.Split(delimiter, source string)
cloudformation.Sub(value string)
Example usage:
There is then a post-processor that replaces the any intrinsics represented as b64 strings, with a proper object, just before the template is marshalled to JSON or YAML.
Pros:
cloudformation.NewString()
andcloudformation.NewInteger()
for every propertyCons:
Fixes #12, #68, #90, #81, #31