do not omit ReturnData in CloudWatch Data Metrics
#254
Conversation
AWS documentation says *ReturnData* This option indicates whether to return the timestamps and raw data values of this metric. If you are performing this call just to do math expressions and do not also need the raw data returned, you can specify False. *If you omit this, the default of True is used.* Then, cloudformation template update with fail with the error: `Exactly one element of the metrics list should return data`, because all the omitted values assumed as `True`
|
Ok, I see that code is autogenerated, but please, take a look when possible. |
|
I have the same error because of ReturnData. The only workaround that worked for me is to use goformation lib as a vendor and modify Alarm_MetricDataQuery struct so it uses a *bool instead of a bool. This way, if not set it is omitted but if it is a pointer to false it is not omitted and the generated stack has a ReturnData = false field. |
|
@goformation @PaulMaddox @grahamjenson could anyone take a look here, please? :) |
|
Similar issue happens with UserPool Mutable field, if you set it to false it is omitted. In general, I think that it would be a good idea to modify all the bool fields to be pointers to bool (*bool). |
|
Similar issue happens with Cloudfront Default Cache Behaviour MinTTL, if you set '0' to forward all the headers the value is omitted. Changing from float64 to *float64 fix it |
|
So the problem is that there are attributes where you want to send the 0 Value, but just removing the I have run into this issue as well. I think one way to solve this is to change the generated attributes to use pointer. e.g. What it should look like is Once you change this, there will no doubt be other places you will have to change, given that after attributes can be nil. What do you think @PaulMaddox? |
|
I'm currently writing an RFC for migrating this library to use pointers everywhere instead of values (and omitempty). This RFC should provide a better path moving forward for fixing this issue everywhere. Once the RFC is ready for review, I will share it for feedback in this repo/issue. |
|
Hi! We believe this issue was fixed when we released v6 of the project. Please feel free to reopen if there's still a problem. |
If it is omitted CloudFormation template update with fail with the error:
Exactly one element of the metrics list should return data, because all the omitted values assumed asTrueFrom the AWS documentation:
ReturnData
This option indicates whether to return the timestamps and raw data values of this metric. If you are performing this call just to do math expressions and do not also need the raw data returned, you can specify False. If you omit this, the default of True is used.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.