-
Notifications
You must be signed in to change notification settings - Fork 121
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kubeflow 1.7 Terraform Deployment Not Working on K8s 1.25 #609
Comments
This is unexpected behavior. On a quick search I dont see any references to where this role is created. Pretty sure I have tried deleting and recreating long time back. This should be fixed On a side note, what do you think about the experience with terraform deployment method? does it bring down some of your heavy lifting on your side and help in making the installation configurable, declarative and maintainable? |
@surajkota Ok tested using aws latest module.kubeflow_components.module.kubeflow_istio_resources.module.helm_addon.helm_release.addon[0]: Creation complete after 2s [id=kubeflow-istio-resources]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Creating...
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [1m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [1m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [1m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [1m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [1m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [1m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [2m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [2m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [2m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [2m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [2m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [2m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [3m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [3m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [3m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [3m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [3m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [3m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [4m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [4m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [4m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [4m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [4m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [4m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [5m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [5m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [5m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [5m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [5m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [5m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [6m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [6m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [6m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [6m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [6m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [6m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [7m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [7m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [7m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [7m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [7m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [7m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [8m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [8m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [8m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [8m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [8m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [8m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [9m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [9m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [9m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [9m30s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [9m40s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [9m50s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [10m0s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [10m10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [10m20s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [10m30s elapsed]
╷
│ Warning: Resource targeting is in effect
│
│ You are creating a plan with the -target option, which means that the
│ result of this plan may not represent all of the changes requested by the
│ current configuration.
│
│ The -target option is not for routine use, and is provided only for
│ exceptional situations such as recovering from errors or mistakes, or when
│ Terraform specifically suggests to use it as part of an error message.
╵
╷
│ Warning: Applied changes may be incomplete
│
│ The plan was created with the -target option in effect, so some changes
│ requested in the configuration may have been ignored and the output values
│ may not be fully updated. Run the following command to verify that no other
│ changes are pending:
│ terraform plan
│
│ Note that the -target option is not suitable for routine use, and is
│ provided only for exceptional situations such as recovering from errors or
│ mistakes, or when Terraform specifically suggests to use it as part of an
│ error message.
╵
╷
│ Warning: Redundant empty provider block
│
│ on cognito-rds-s3-components/main.tf line 1:
│ 1: provider "aws" {
│
│ Earlier versions of Terraform used empty provider blocks ("proxy provider
│ configurations") for child modules to declare their need to be passed a
│ provider configuration by their callers. That approach was ambiguous and is
│ now deprecated.
│
│ If you control this module, you can migrate to the new declaration syntax
│ by removing all of the empty provider "aws" blocks and then adding or
│ updating an entry like the following to the required_providers block of
│ module.kubeflow_components:
│ aws = {
│ source = "hashicorp/aws"
│ configuration_aliases = [
│ aws.aws,
│ aws.virginia,
│ ]
│ }
│
│ (and one more similar warning elsewhere)
╵
╷
│ Warning: Experimental feature "module_variable_optional_attrs" is active
│
│ on .terraform/modules/eks_blueprints_kubernetes_addons.ondat/locals.tf line 2, in terraform:
│ 2: experiments = [module_variable_optional_attrs]
│
│ Experimental features are subject to breaking changes in future minor or
│ patch releases, based on feedback.
│
│ If you have feedback on the design of this feature, please open a GitHub
│ issue to discuss it.
│
│ (and 7 more similar warnings elsewhere)
╵
╷
│ Warning: "default_secret_name" is no longer applicable for Kubernetes v1.24.0 and above
│
│ with module.kubeflow_components.module.kubeflow_secrets_manager_irsa.kubernetes_service_account_v1.irsa[0],
│ on .terraform/modules/kubeflow_components.kubeflow_secrets_manager_irsa/modules/irsa/main.tf line 16, in resource "kubernetes_service_account_v1" "irsa":
│ 16: resource "kubernetes_service_account_v1" "irsa" {
│
│ Starting from version 1.24.0 Kubernetes does not automatically generate a
│ token for service accounts, in this case, "default_secret_name" will be
│ empty
╵
╷
│ Warning: Helm release "kubeflow-pipelines" was created but has a failed status. Use the `helm` command to investigate the error, correct it, then run Terraform again.
│
│ with module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0],
│ on .terraform/modules/kubeflow_components.kubeflow_pipelines.helm_addon/modules/kubernetes-addons/helm-addon/main.tf line 1, in resource "helm_release" "addon":
│ 1: resource "helm_release" "addon" {
│
╵
╷
│ Error: timed out waiting for the condition
│
│ with module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0],
│ on .terraform/modules/kubeflow_components.kubeflow_pipelines.helm_addon/modules/kubernetes-addons/helm-addon/main.tf line 1, in resource "helm_release" "addon":
│ 1: resource "helm_release" "addon" {
│
╵
make: *** [deploy-kubeflow-components] Error 1
Makefile:30: recipe for target 'deploy-kubeflow-components' failed As for the role, it created the role automatically again when I ran the deployment using Terraform : Therefore I'm afraid that the
I was not able to get an install working yet with Terraform but the deployment feels much nicer compared to Kustomize. I think Terraform deployment option will probably easier to adapt to our needs, we'll be able to make PR to add missing variables in the |
Need to check the pods related to pipelines. Pipelines installation is failing, do you see any errors? cc @ryansteakley @jsitu777 any idea why this might be happening? is pipelines helm chart for rds-s3 up to date for 1.7? |
@surajkota @ryansteakley @jsitu777 Just tested using latest main (new commits were added since last week test) :
Now I get a different error : module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Creating...
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [10s elapsed]
module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0]: Still creating... [20s elapsed]
╷
│ Warning: Resource targeting is in effect
│
│ You are creating a plan with the -target option, which means that the
│ result of this plan may not represent all of the changes requested by the
│ current configuration.
│
│ The -target option is not for routine use, and is provided only for
│ exceptional situations such as recovering from errors or mistakes, or when
│ Terraform specifically suggests to use it as part of an error message.
╵
╷
│ Warning: Applied changes may be incomplete
│
│ The plan was created with the -target option in effect, so some changes
│ requested in the configuration may have been ignored and the output values
│ may not be fully updated. Run the following command to verify that no other
│ changes are pending:
│ terraform plan
│
│ Note that the -target option is not suitable for routine use, and is
│ provided only for exceptional situations such as recovering from errors or
│ mistakes, or when Terraform specifically suggests to use it as part of an
│ error message.
╵
╷
│ Warning: Redundant empty provider block
│
│ on cognito-rds-s3-components/main.tf line 1:
│ 1: provider "aws" {
│
│ Earlier versions of Terraform used empty provider blocks ("proxy provider
│ configurations") for child modules to declare their need to be passed a
│ provider configuration by their callers. That approach was ambiguous and is
│ now deprecated.
│
│ If you control this module, you can migrate to the new declaration syntax
│ by removing all of the empty provider "aws" blocks and then adding or
│ updating an entry like the following to the required_providers block of
│ module.kubeflow_components:
│ aws = {
│ source = "hashicorp/aws"
│ configuration_aliases = [
│ aws.aws,
│ aws.virginia,
│ ]
│ }
│
│ (and one more similar warning elsewhere)
╵
╷
│ Warning: Experimental feature "module_variable_optional_attrs" is active
│
│ on .terraform/modules/eks_blueprints_kubernetes_addons.ondat/locals.tf line 2, in terraform:
│ 2: experiments = [module_variable_optional_attrs]
│
│ Experimental features are subject to breaking changes in future minor or
│ patch releases, based on feedback.
│
│ If you have feedback on the design of this feature, please open a GitHub
│ issue to discuss it.
│
│ (and 7 more similar warnings elsewhere)
╵
╷
│ Warning: "default_secret_name" is no longer applicable for Kubernetes v1.24.0 and above
│
│ with module.kubeflow_components.module.kubeflow_secrets_manager_irsa.kubernetes_service_account_v1.irsa[0],
│ on .terraform/modules/kubeflow_components.kubeflow_secrets_manager_irsa/modules/irsa/main.tf line 16, in resource "kubernetes_service_account_v1" "irsa":
│ 16: resource "kubernetes_service_account_v1" "irsa" {
│
│ Starting from version 1.24.0 Kubernetes does not automatically generate a
│ token for service accounts, in this case, "default_secret_name" will be
│ empty
╵
╷
│ Error: rendered manifests contain a resource that already exists. Unable to continue with install: Secret "mlpipeline-minio-artifact" in namespace "kubeflow" exists and cannot be imported into the current release: invalid ownership metadata; label validation error: missing key "app.kubernetes.io/managed-by": must be set to "Helm"; annotation validation error: missing key "meta.helm.sh/release-name": must be set to "kubeflow-pipelines"; annotation validation error: missing key "meta.helm.sh/release-namespace": must be set to "default"
│
│ with module.kubeflow_components.module.kubeflow_pipelines.module.helm_addon.helm_release.addon[0],
│ on .terraform/modules/kubeflow_components.kubeflow_pipelines.helm_addon/modules/kubernetes-addons/helm-addon/main.tf line 1, in resource "helm_release" "addon":
│ 1: resource "helm_release" "addon" {
│
╵
make: *** [deploy-kubeflow-components] Error 1
Makefile:30: recipe for target 'deploy-kubeflow-components' failed Also, all pods were running when checking with |
@AlexandreBrown Which deployment option with terraform was this? Can you try running the terraform deployment off of the pr I have open? |
@ryansteakley Using Terraform RDS-S3-Cognio deployment option.
Note that the IAM user for my test has full administrator access so this is a bit unexpected to me.
|
@ryansteakley I tested using your branch with your fix (new commit). module.kubeflow_components.module.kubeflow_aws_telemetry[0].module.helm_addon.helm_release.addon[0]: Creating...
╷
│ Warning: Resource targeting is in effect
│
│ You are creating a plan with the -target option, which means that the
│ result of this plan may not represent all of the changes requested by the
│ current configuration.
│
│ The -target option is not for routine use, and is provided only for
│ exceptional situations such as recovering from errors or mistakes, or when
│ Terraform specifically suggests to use it as part of an error message.
╵
╷
│ Warning: Applied changes may be incomplete
│
│ The plan was created with the -target option in effect, so some changes
│ requested in the configuration may have been ignored and the output values
│ may not be fully updated. Run the following command to verify that no other
│ changes are pending:
│ terraform plan
│
│ Note that the -target option is not suitable for routine use, and is
│ provided only for exceptional situations such as recovering from errors or
│ mistakes, or when Terraform specifically suggests to use it as part of an
│ error message.
╵
╷
│ Warning: Redundant empty provider block
│
│ on cognito-rds-s3-components/main.tf line 1:
│ 1: provider "aws" {
│
│ Earlier versions of Terraform used empty provider blocks ("proxy provider
│ configurations") for child modules to declare their need to be passed a
│ provider configuration by their callers. That approach was ambiguous and is
│ now deprecated.
│
│ If you control this module, you can migrate to the new declaration syntax
│ by removing all of the empty provider "aws" blocks and then adding or
│ updating an entry like the following to the required_providers block of
│ module.kubeflow_components:
│ aws = {
│ source = "hashicorp/aws"
│ configuration_aliases = [
│ aws.aws,
│ aws.virginia,
│ ]
│ }
│
│ (and one more similar warning elsewhere)
╵
╷
│ Warning: Experimental feature "module_variable_optional_attrs" is active
│
│ on .terraform/modules/eks_blueprints_kubernetes_addons.ondat/locals.tf line 2, in terraform:
│ 2: experiments = [module_variable_optional_attrs]
│
│ Experimental features are subject to breaking changes in future minor or
│ patch releases, based on feedback.
│
│ If you have feedback on the design of this feature, please open a GitHub
│ issue to discuss it.
│
│ (and 7 more similar warnings elsewhere)
╵
╷
│ Warning: "default_secret_name" is no longer applicable for Kubernetes v1.24.0 and above
│
│ with module.kubeflow_components.module.kubeflow_secrets_manager_irsa.kubernetes_service_account_v1.irsa[0],
│ on .terraform/modules/kubeflow_components.kubeflow_secrets_manager_irsa/modules/irsa/main.tf line 16, in resource "kubernetes_service_account_v1" "irsa":
│ 16: resource "kubernetes_service_account_v1" "irsa" {
│
│ Starting from version 1.24.0 Kubernetes does not automatically generate a
│ token for service accounts, in this case, "default_secret_name" will be
│ empty
╵
╷
│ Error: unable to build kubernetes objects from release manifest: resource mapping not found for name: "aws-kubeflow-telemetry" namespace: "kubeflow" from "": no matches for kind "CronJob" in version "batch/v1beta1"
│ ensure CRDs are installed first
│
│ with module.kubeflow_components.module.kubeflow_aws_telemetry[0].module.helm_addon.helm_release.addon[0],
│ on .terraform/modules/kubeflow_components.kubeflow_aws_telemetry.helm_addon/modules/kubernetes-addons/helm-addon/main.tf line 1, in resource "helm_release" "addon":
│ 1: resource "helm_release" "addon" {
│
╵
make: *** [deploy-kubeflow-components] Error 1
Makefile:30: recipe for target 'deploy-kubeflow-components' failed I think the issue is that for Kubernetes Line 1 in 979e61d
|
That's right, we are testing on 1.24. need to update this for 1.25, there might be more such things for 1.25 |
@surajkota I see. |
@surajkota @ryansteakley @jsitu777 Just tested the fix from my branch 62c84cb . from kfp import dsl
import kfp
@dsl.component
def add(a: float, b: float) -> float:
'''Calculates sum of two arguments'''
return a + b
@dsl.pipeline(
name='Addition pipeline',
description='An example pipeline that performs addition calculations.')
def add_pipeline(
a: float = 1.0,
b: float = 7.0,
):
first_add_task = add(a=a, b=4.0)
second_add_task = add(a=first_add_task.output, b=b)
from kfp import Client
# This is the "Domain" in your cookies. eg: kubeflow.<platform.example.com>
kubeflow_gateway_endpoint="THE VALUE HERE"
alb_session_cookie0="THE VALUE HERE"
alb_session_cookie1="THE VALUE HERE"
namespace="alex"
client = Client(host=f"https://{kubeflow_gateway_endpoint}/pipeline", cookies=f"AWSELBAuthSessionCookie-0={alb_session_cookie0};AWSELBAuthSessionCookie-1={alb_session_cookie1}", namespace=namespace)
client.create_run_from_pipeline_func(
add_pipeline, arguments={
'a': 7.0,
'b': 8.0
}) kubectl logs addition-pipeline-tm2tl-478962274 -n alex Output time="2023-03-30T01:23:35.396Z" level=info msg="capturing logs" argo=true
time="2023-03-30T01:23:35.418Z" level=info msg="capturing logs" argo=true
I0330 01:23:35.430078 29 cache.go:139] Cannot detect ml-pipeline in the same namespace, default to ml-pipeline.kubeflow:8887 as KFP endpoint.
I0330 01:23:35.430089 29 cache.go:116] Connecting to cache endpoint ml-pipeline.kubeflow:8887
F0330 01:23:35.538427 29 main.go:49] failed to execute component: Failed to open bucket "mlpipeline": Failed to get minio credential: Failed to get MinIO credential from secret name="mlpipeline-minio-artifact" namespace="alex": does not have 'accesskey' key
Error: exit status 1
Error: exit status 1 kubectl describe secret mlpipeline-minio-artifact -n alex Output Name: mlpipeline-minio-artifact
Namespace: alex
Labels: controller-uid=5012a9df-3d4e-460c-9b5e-85546e8da6d2
Annotations: metacontroller.k8s.io/last-applied-configuration:
{"apiVersion":"v1","data":{"accesskey":"","secretkey":""},"kind":"Secret","metadata":{"labels":{"controller-uid":"5012a9df-3d4e-460c-9b5e-...
Type: Opaque
Data
====
accesskey: 0 bytes
secretkey: 0 bytes Could this be because the Kubeflow Pipeline version on |
@AlexandreBrown don't expect for v2 to work even with the latest version, since kfp v2 has different source code, after looking into it, they grab credentials differerntly from v1 and have hard-coded it to use static credentials from that secret https://github.com/kubeflow/pipelines/blob/d2db64bebbd214e55c5ccde38dc1c7c7cab27dda/backend/src/v2/objectstore/object_store.go#L54 |
@ryansteakley thanks for the feedback. Do you think we can fix this easily? Our team want to use v2 after we upgrade Kubeflow. |
Do not think it is a heavily complex change, however would need to get the pr merged in the upstream pipelines repo, which would take time. |
Based on the code, looks like the current static credentials mechanism will still work. Can you try using that for this release? We will plan to evaluate both rds and S3 support for kfpv2 in the next release when they plan to release beta |
@surajkota @ryansteakley ok, we'll try using the static credentials for this release then. Would that means we cannot use the Kubeflow IAM profile plugin when creating profile? What s the procedure for static credentials? To use the script I made back then or does the terraform deployment option handles it ? https://awslabs.github.io/kubeflow-manifests/docs/component-guides/notebooks/#set-up-secrets-access ? Also regarding the change I tested (changing the api version from batch/v1beta to batch/v1), would this change be backward compatible with 1.24? Sure it will fix it for us since we plan on using k8s 1.25 but will it affect |
Yes, it will be backward compatible. +1 to change it
You can still use it, just that pipelines will not use those credentials, it will still use the IAM user credentials
There should be a argument for it. We haven't made the doc changes. Some of the PRs are still in review though |
- v1beta was changed to v1 in Kubernetes 1.25 **Which issue is resolved by this Pull Request:** Resolves #609 **Description of your changes:** **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
- v1beta was changed to v1 in Kubernetes 1.25 **Which issue is resolved by this Pull Request:** Resolves awslabs#609 **Description of your changes:** **Testing:** - [ ] Unit tests pass - [ ] e2e tests pass - Details about new tests (If this PR adds a new feature) - Details about any manual tests performed By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.
Describe the bug
I ran into a timeout issue during the installation of Kubeflow 1.6.1 using AWS RDS S3 Cognito Terraform
make deploy
command.I ran the
make delete
command to delete created resources since the install was only partial.Running the
make delete
command did not delete the resources.Failed install logs tail:
Make delete relevant logs:
Destroy complete! Resources: 0 destroyed.
(I can provide the full log on requst but it's pretty long and repeteitive with the same output as the one above.
Steps To Reproduce
deploy.Dockerfile
docker run --rm kf-deployment make delete
(or change the CMD part of the docker file and rebuild and re-run if you prefer).creating IAM Role (kf-test-cluster-role): EntityAlreadyExists: Role with name kf-test-cluster-role already exists.
(kf-test is my cluster name).Expected behavior
I expected no timeout but it can happen, if we can customize the timeout period it would be great, I don't mind waiting 1hour for the install I just want it to get done.
As for the
make delete
, it should delete all resources created otherwiseEnvironment
The text was updated successfully, but these errors were encountered: