Update CRT HeadersError::HeaderNotFound to include header name #1205
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR benchmarks
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
dannycjones
requested a deployment
to
PR integration tests
GitHub Actions
Waiting
Signed-off-by: Daniel Carl Jones <djonesoa@amazon.com>
dannycjones
force-pushed
the
add-header-name-to-header-not-found-crt
branch
from
08c23cb to
61a5878
Compare
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR benchmarks
GitHub Actions
Inactive
dannycjones
temporarily deployed
to
PR integration tests
GitHub Actions
Inactive
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We recently saw an error in #1199 where "Header not found" was emitted, but its really unclear what header was missing.
This change updates the
HeadersError::HeaderNotFoundenum variant to contain a copy of the header name, such that error messages can emit it for debugging purposes.I think it would make more sense to have all the headers we're interested in statically defined somewhere, such that we could include a static reference to the header and avoid allocating for an error message. However, we don't expect there to be any performance regression introduced by this change. We could take an action to move to static values later.
Does this change impact existing behavior?
Header not found errors will now include the header name when printing the error message.
The enum variant changes meaning any code using the enum may be impacted.
Does this change need a changelog entry?
Not for Mountpoint itself. I have added a change log entry to
mountpoint-s3-crtsince it is a breaking API change.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license and I agree to the terms of the Developer Certificate of Origin (DCO).