chore: Consider an absent condition to be Unknown #106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jonathan-innis
commented
Nov 25, 2024
jonathan-innis
force-pushed
the
consider-absent-unknown
branch
from
96de1a1
to
cc3db56
Compare
jonathan-innis
force-pushed
the
consider-absent-unknown
branch
2 times, most recently
from
66012a2
to
35ecca4
Compare
jonathan-innis
force-pushed
the
consider-absent-unknown
branch
from
35ecca4
to
9c8eb0d
Compare
ellistarn
reviewed
Nov 25, 2024
ellistarn
reviewed
Nov 25, 2024
ellistarn
reviewed
Nov 25, 2024
ellistarn
reviewed
Nov 25, 2024
ellistarn
reviewed
Nov 25, 2024
jonathan-innis
force-pushed
the
consider-absent-unknown
branch
3 times, most recently
from
91a63d6
to
cc1ecca
Compare
jonathan-innis
force-pushed
the
consider-absent-unknown
branch
from
cc1ecca
to
1a0b2a9
Compare
ellistarn
approved these changes
Nov 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #, if available:
Description of changes:
This change updates our condition logic so that we consider a lack of a condition as a condition in an
Unknownstatus. This also ensures that the first time that we set the StatusCondition that it's set to the CreationTimestamp since the first time that we set the condition, the condition hasn't transitioned so the "LastTransitionTime" of this condition was actually when the object was createdBy submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.