Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add client-go metrics registration to operatorpkg #55

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

jonathan-innis
Copy link
Contributor

@jonathan-innis jonathan-innis commented Jun 28, 2024

Issue #, if available:

Description of changes:

Add the ability to register client metrics with the RegisterClientMetrics() call.

When calling the metrics endpoint, we see the following output reflecting the updated metrics that are returned here -- which reflects the actual apiserver calls that are made (not hitting the controller-runtime cache)

client_go_request_duration_seconds_count{group="",kind="events",subresource="",verb="PATCH",version="v1"} 10
client_go_request_duration_seconds_count{group="",kind="nodes",subresource="",verb="DELETE",version="v1"} 12
client_go_request_duration_seconds_count{group="",kind="nodes",subresource="",verb="LIST",version="v1"} 1
client_go_request_duration_seconds_count{group="",kind="nodes",subresource="",verb="PATCH",version="v1"} 12
client_go_request_duration_seconds_count{group="",kind="pods",subresource="",verb="LIST",version="v1"} 1
client_go_request_duration_seconds_count{group="",kind="pods",subresource="eviction",verb="CREATE",version="v1"} 29
client_go_request_duration_seconds_count{group="",kind="services",subresource="",verb="GET",version="v1"} 1
client_go_request_duration_seconds_count{group="apps",kind="daemonsets",subresource="",verb="LIST",version="v1"} 1
client_go_request_duration_seconds_count{group="coordination.k8s.io",kind="leases",subresource="",verb="GET",version="v1"} 3
client_go_request_duration_seconds_count{group="coordination.k8s.io",kind="leases",subresource="",verb="LIST",version="v1"} 1
client_go_request_duration_seconds_count{group="coordination.k8s.io",kind="leases",subresource="",verb="UPDATE",version="v1"} 78
client_go_request_duration_seconds_count{group="karpenter.k8s.aws",kind="ec2nodeclasses",subresource="",verb="LIST",version="v1beta1"} 2
client_go_request_duration_seconds_count{group="karpenter.sh",kind="nodeclaims",subresource="",verb="CREATE",version="v1beta1"} 12
client_go_request_duration_seconds_count{group="karpenter.sh",kind="nodeclaims",subresource="",verb="LIST",version="v1beta1"} 1
client_go_request_duration_seconds_count{group="karpenter.sh",kind="nodeclaims",subresource="",verb="PATCH",version="v1beta1"} 24
client_go_request_duration_seconds_count{group="karpenter.sh",kind="nodeclaims",subresource="status",verb="PATCH",version="v1beta1"} 12
client_go_request_duration_seconds_count{group="karpenter.sh",kind="nodeclaims",subresource="status",verb="UPDATE",version="v1beta1"} 40
client_go_request_duration_seconds_count{group="karpenter.sh",kind="nodepools",subresource="",verb="LIST",version="v1beta1"} 1
client_go_request_duration_seconds_count{group="karpenter.sh",kind="nodepools",subresource="status",verb="PATCH",version="v1beta1"} 14
client_go_request_duration_seconds_count{group="policy",kind="poddisruptionbudgets",subresource="",verb="LIST",version="v1"} 1
client_go_request_duration_seconds_count{group="storage.k8s.io",kind="csinodes",subresource="",verb="LIST",version="v1"} 1

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jonathan-innis jonathan-innis requested a review from a team as a code owner June 28, 2024 20:30
@jonathan-innis jonathan-innis force-pushed the add-kube-client-metrics branch 2 times, most recently from 962ea8c to e1d867b Compare June 28, 2024 20:32
@jonathan-innis jonathan-innis changed the title feat: Add kube-client metrics to operatorpkg feat: Add client-go metrics registration to operatorpkg Jun 28, 2024
@jonathan-innis jonathan-innis force-pushed the add-kube-client-metrics branch 2 times, most recently from e620d18 to b1b57bc Compare June 28, 2024 20:35
@jonathan-innis jonathan-innis merged commit 2457d6a into awslabs:main Jun 28, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants