Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: support namespaces requests for client-go metrics #56

Merged
merged 1 commit into from
Jul 1, 2024

Conversation

jmdeal
Copy link
Contributor

@jmdeal jmdeal commented Jul 1, 2024

Issue #, if available:

Description of changes:
Don't panic for the following requests for client-go metrics:

  • /api/v1/namespaces
  • /api/v1/namespaces/{name}

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@jmdeal jmdeal requested a review from a team as a code owner July 1, 2024 17:16
@jmdeal jmdeal force-pushed the fix/metrics-namespaces branch 2 times, most recently from 19ac9e3 to 946dc2c Compare July 1, 2024 17:17
Copy link
Contributor

@jonathan-innis jonathan-innis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :Rocekt

@jonathan-innis jonathan-innis merged commit bdd9eb9 into awslabs:main Jul 1, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants