Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release v0.13 #250

Merged
merged 10 commits into from
May 20, 2024
Merged

Release v0.13 #250

merged 10 commits into from
May 20, 2024

Conversation

sebastiangrimberg
Copy link
Contributor

Final changes for Palace version 0.13.

@sebastiangrimberg sebastiangrimberg added the release Related to releases label May 14, 2024
@sebastiangrimberg sebastiangrimberg force-pushed the sjg/release-0.13 branch 2 times, most recently from 3109531 to 1eb3c3d Compare May 16, 2024 19:45
Copy link
Collaborator

@hughcars hughcars left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Ran some adapts and all looked fine.

Comment on lines +163 to +168
export FC=gfortran-12
export LDFLAGS='-fuse-ld=lld'
elif [[ "${{ matrix.compiler }}" == 'gcc' ]]; then
export CC=gcc-13
export CXX=g++-13
export FC=gfortran-13
export CC=gcc-12
export CXX=g++-12
export FC=gfortran-12
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there an issue with gcc13?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No issue, it just got removed from the Ubuntu image used for GitHub Actions (not sure why). See actions/runner-images@cfcc1c6.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I guess this was an intentional decision: actions/runner-images#9866.

@sebastiangrimberg sebastiangrimberg merged commit a61c8cb into main May 20, 2024
17 checks passed
@sebastiangrimberg sebastiangrimberg deleted the sjg/release-0.13 branch May 20, 2024 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release Related to releases
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants