Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert cc to 1.0.83 to fix wheels build workflow #144

Merged
merged 4 commits into from
Feb 14, 2024

Conversation

dnanuti
Copy link
Contributor

@dnanuti dnanuti commented Feb 13, 2024

Description

Revert cc to 1.0.83 to fix wheels build workflow

Additional context

We were seeing this error after a Cargo update:

[  0%] Generating curve25519/curve25519_x25519base_alt.S.S
        
          --- stderr
          libunwind not found. Disabling unwind tests.
          Copying platform assembly files from /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/mountpoint-s3-crt-sys-0.5.3/crt/aws-lc/generated-src/linux-x86_64/crypto/ to /project/s3torchconnectorclient/target/release/build/mountpoint-s3-crt-sys-24feb138cf4a244b/out/build/aws-lc/build/crypto
          gmake[1]: *** read jobs pipe: Resource temporarily unavailable.  Stop.
          gmake[1]: *** Waiting for unfinished jobs....
          gmake[2]: *** read jobs pipe: Resource temporarily unavailable.  Stop.
          gmake[2]: *** Waiting for unfinished jobs....
          gmake[1]: *** [crypto/fipsmodule/CMakeFiles/fipsmodule.dir/all] Error 2
          gmake: *** [all] Error 2
          thread 'main' panicked at /root/.cargo/registry/src/index.crates.io-6f17d22bba15001f/cmake-0.1.50/src/lib.rs:1098:5:
        
          command did not execute successfully, got: exit status: 2
        
          build script failed, must exit now
          note: run with `RUST_BACKTRACE=1` environment variable to display a backtrace
        warning: build failed, waiting for other jobs to finish...
        cargo rustc --lib --message-format=json-render-diagnostics --manifest-path Cargo.toml --release -v --features pyo3/extension-module --crate-type cdylib --
        error: `cargo rustc --lib --message-format=json-render-diagnostics --manifest-path Cargo.toml --release -v --features pyo3/extension-module --crate-type cdylib --` failed with code 101
        [end of output]

We have updated the cc crate, which is:

A build-time dependency for Cargo build scripts to assist in invoking the native C compiler to compile native C code into a static archive to be linked into Rust code.”

We were using cc 1.0.85, that was causing the failure (and had different Github issues such as: rust-lang/cc-rs#948).

The owners for cc yanked the previous 2 revisions, so reverting back to 1.0.83 resolved the issue on our end, but with this occasion we learned that there are multiple crates depending on cc, including cmake and CRT.

Related items

Testing


By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.

@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@dnanuti dnanuti temporarily deployed to integration-tests February 13, 2024 18:31 — with GitHub Actions Inactive
@@ -54,7 +54,7 @@ jobs:
mv NOTICE_DEFAULT THIRD-PARTY-LICENSES

- name: Build wheels for s3torchconnectorclient
uses: pypa/cibuildwheel@v2.16.2
uses: pypa/cibuildwheel@v2.16.5
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I know we were planning to do this, but is it necessary for this PR?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No, but I tested with this as well afterwards, so I thought of including it

@dnanuti dnanuti merged commit 4d7ddc8 into main Feb 14, 2024
27 checks passed
@dnanuti dnanuti deleted the workflow/update-cibuildwheel branch February 14, 2024 10:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants