-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Revert cc to 1.0.83 to fix wheels build workflow #144
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
dnanuti
temporarily deployed
to
integration-tests
February 13, 2024 18:31 — with
GitHub Actions
Inactive
IsaevIlya
approved these changes
Feb 13, 2024
muddyfish
reviewed
Feb 14, 2024
@@ -54,7 +54,7 @@ jobs: | |||
mv NOTICE_DEFAULT THIRD-PARTY-LICENSES | |||
|
|||
- name: Build wheels for s3torchconnectorclient | |||
uses: pypa/cibuildwheel@v2.16.2 | |||
uses: pypa/cibuildwheel@v2.16.5 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know we were planning to do this, but is it necessary for this PR?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No, but I tested with this as well afterwards, so I thought of including it
muddyfish
approved these changes
Feb 14, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Revert cc to 1.0.83 to fix wheels build workflow
Additional context
We were seeing this error after a Cargo update:
We have updated the
cc
crate, which is:We were using cc 1.0.85, that was causing the failure (and had different Github issues such as: rust-lang/cc-rs#948).
The owners for cc yanked the previous 2 revisions, so reverting back to 1.0.83 resolved the issue on our end, but with this occasion we learned that there are multiple crates depending on cc, including cmake and CRT.
Related items
Testing
By submitting this pull request, I confirm that my contribution is made under the terms of BSD 3-Clause License and I agree to the terms of the LICENSE.