Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feat] Use S3VPCE to prevent S3 access outside of VPC #1183

Merged
merged 1 commit into from
Apr 28, 2023
Merged

[feat] Use S3VPCE to prevent S3 access outside of VPC #1183

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions ...ns/addon-base-raas/packages/base-raas-cfn-templates/src/templates/onboard-account.cfn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1228,7 +1228,9 @@ Outputs:
Condition: isAppStreamAndCustomDomain
Value: !Ref Route53HostedZone

S3VpcEndpoint:
S3VPCE:
Description: S3 interface endpoint
Condition: isAppStream
Value: !Ref S3Endpoint
Value: !Ref S3Endpoint
Export:
Name: !Join [ '', [ Ref: Namespace, '-S3VPCE' ] ]
8 changes: 8 additions & 0 deletions ...base-raas-cfn-templates/src/templates/service-catalog/sagemaker-notebook-instance.cfn.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -122,6 +122,14 @@ Resources:
- sagemaker:DescribeNotebookInstance
- sagemaker:StopNotebookInstance
Resource: '*'
- Effect: Deny
Action: 's3:*'
Resource: '*'
Condition:
StringNotEquals:
aws:SourceVpce:
Fn::ImportValue: !Sub '${SolutionNamespace}-S3VPCE'


IAMRoleSageMakerURL:
Type: 'AWS::IAM::Role'
Expand Down