Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

chore: upgrade dependencies #547

Closed
wants to merge 1 commit into from
Closed

chore: upgrade dependencies #547

wants to merge 1 commit into from

Conversation

SanketD92
Copy link
Contributor

Issue #, if available:
N/A

Description of changes:
Dependabot suggested upgrade.

Checklist:

  • Have you successfully deployed to an AWS account with your changes?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@SanketD92 SanketD92 requested a review from a team as a code owner June 24, 2021 17:07
@codecov
Copy link

codecov bot commented Jun 24, 2021

Codecov Report

Merging #547 (709422e) into develop (2be27d1) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #547   +/-   ##
========================================
  Coverage    49.04%   49.04%           
========================================
  Files          243      243           
  Lines        12503    12503           
  Branches      2014     2014           
========================================
  Hits          6132     6132           
  Misses        5564     5564           
  Partials       807      807           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2be27d1...709422e. Read the comment docs.

Copy link
Contributor

@carvantes carvantes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The dependabot PR was slightly better #546.

Resolutions should only be used as a last resort. In this case it's not strictly needed since 1.5.5 is compatible with the existing requirement of color-string@^1.5.4

Was there a reason to not simply accept the dependabot PR?

btw, you can upgrade a transitive dependency by deleting it from yarn.lock and reinstalling it https://medium.com/@ayushya/upgrading-javascript-packages-deep-dependencies-using-yarn-8b5983d5fb6b

yarn upgrade doesn't work for transitives: yarnpkg/yarn#4986

@SanketD92
Copy link
Contributor Author

The dependabot PR was slightly better #546.

Resolutions should only be used as a last resort. In this case it's not strictly needed since 1.5.5 is compatible with the existing requirement of color-string@^1.5.4

Was there a reason to not simply accept the dependabot PR?

btw, you can upgrade a transitive dependency by deleting it from yarn.lock and reinstalling it https://medium.com/@ayushya/upgrading-javascript-packages-deep-dependencies-using-yarn-8b5983d5fb6b

yarn upgrade doesn't work for transitives: yarnpkg/yarn#4986

The dependabot PR was made against mainline. Instead of changing base and pushing an empty commit (for semantic check to work), I just created a new PR altogether. I can reopen that PR and close this out.

@SanketD92 SanketD92 closed this Jun 24, 2021
@SanketD92 SanketD92 deleted the chore-upgrade-deps branch October 25, 2021 19:38
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants