Skip to content
This repository has been archived by the owner on Dec 6, 2024. It is now read-only.

feat: Add user's email to JSON response of egress request #771

Merged
merged 2 commits into from
Oct 26, 2021

Conversation

nguyen102
Copy link
Contributor

@nguyen102 nguyen102 commented Oct 25, 2021

Issue #, if available:

Description of changes:
Per new customer requirements I've added two new fields to the response of an Egress Data request. The new fields are updated_by_email and created_by_email.

Testing
I deployed the new code, submitted an egress request, and checked that the response has the newly added fields.

{
    "egress_store_object_list_location": "<REDACTED>/sagemaker-11-egress-store-ver1.json",
    "id": "<REDACTED>",
    "egress_store_id": "<REDACTED>",
    "egress_store_name": "sagemaker-11-egress-store",
    "created_at": "2021-10-15T19:03:09.367Z",
    "created_by": "<REDACTED>",
    "created_by_email": "<REDACTED>@amazon.com",
    "workspace_id": "<REDACTED>",
    "project_id": "proj-new-account-1",
    "s3_bucketname": "<REDACTED>",
    "s3_bucketpath": "<REDACTED>/",
    "status": "PENDING",
    "updated_by": "<REDACTED>",
    "updated_by_email": "<REDACTED>@amazon.com",
    "updated_at": "2021-10-25T18:45:02.883Z",
    "ver": 1
}

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@codecov
Copy link

codecov bot commented Oct 25, 2021

Codecov Report

Merging #771 (0fa76cf) into develop (b10f4b0) will increase coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #771   +/-   ##
========================================
  Coverage    52.09%   52.10%           
========================================
  Files          272      272           
  Lines        14519    14522    +3     
  Branches      2285     2285           
========================================
+ Hits          7563     7566    +3     
  Misses        6106     6106           
  Partials       850      850           
Impacted Files Coverage Δ
lib/data-egress/data-egress-service.js 95.41% <0.00%> (+0.05%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b10f4b0...0fa76cf. Read the comment docs.

@nguyen102 nguyen102 marked this pull request as ready for review October 25, 2021 19:50
@nguyen102 nguyen102 requested a review from a team as a code owner October 25, 2021 19:50
Copy link
Contributor

@SanketD92 SanketD92 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nguyen102 nguyen102 merged commit e3c6c22 into awslabs:develop Oct 26, 2021
@nguyen102 nguyen102 deleted the egress-request-email-fields branch January 4, 2022 02:26
jxuamazon pushed a commit to jxuamazon/service-workbench-on-aws that referenced this pull request Feb 15, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants