Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Docs: Relevance labs changes #996

Merged
merged 3 commits into from
May 25, 2022
Merged

Docs: Relevance labs changes #996

merged 3 commits into from
May 25, 2022

Conversation

brandroid-tw
Copy link
Contributor

Issue #, if available:

Description of changes:

Checklist:

  • Have you successfully deployed to an AWS account with your changes?
  • Have you written new tests for your core changes, as applicable?
  • Have you successfully tested with your changes locally?
  • If new dependencies have been added, have they been pinned to specific versions?
  • Is this change also required on the AWS Solution version?
  • Have you updated openapi.yaml if you made updates to API definition (including add, delete or update parameter and request data schema)?
  • If you had to run manual tests, have you considered automating those tests by adding them to end-to-end tests?
  • If you are updating the changelog and vending out a new release, have you updated versionNumber and versionDate in .defaults.yml

AS review ticket id:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@brandroid-tw brandroid-tw requested a review from a team as a code owner May 20, 2022 13:36
@codecov
Copy link

codecov bot commented May 20, 2022

Codecov Report

Merging #996 (037ebab) into develop (54590a0) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop     #996   +/-   ##
========================================
  Coverage    51.70%   51.70%           
========================================
  Files          295      295           
  Lines        16895    16895           
  Branches      2631     2632    +1     
========================================
  Hits          8735     8735           
  Misses        7170     7170           
  Partials       990      990           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 54590a0...037ebab. Read the comment docs.

Copy link
Contributor

@FernandoAranda FernandoAranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In Service_Workbench_Install_Guide.pdf
Page 9:
-(Knit) enableAMISharing section:
Can we describe what AMI means or offer a link for details?
- disableStudyUploadbyResearcher section:
"A user will not be able files or create a study...."
Did you mean: "A user will not be able to access files or create a study..."?

In Service_Workbench_Post_Deployment_Guide.pdf
Page 33
-(Knit) Deploying Updates section:
command next to "Deploying Updates to the Prepare Devops Account Serverless Project" does not have the same format as
other commands

@brandroid-tw
Copy link
Contributor Author

Going to update the install guide. For post-deployment, I intentionally didn't take the extra time to match the formatting since that doc is soon to be replaced by a completely new version.

@nguyen102 nguyen102 merged commit 8dcef6b into develop May 25, 2022
@nguyen102 nguyen102 deleted the relevancelabupdates branch May 25, 2022 02:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants