Bump futures dependency
#107
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We have a test that relies on `FuturesUnordered` implementing `IntoIter`, but this is only the case since 0.3.15. https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md#0315---2021-05-11
jamesbornholt
approved these changes
May 23, 2023
jorajeev
pushed a commit
that referenced
this pull request
Feb 29, 2024
We have a test that relies on `FuturesUnordered` implementing `IntoIter`, but this is only the case since 0.3.15. https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md#0315---2021-05-11
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have a test that relies on
FuturesUnorderedimplementingIntoIter, but this is only the case since 0.3.15 (https://github.com/rust-lang/futures-rs/blob/master/CHANGELOG.md#0315---2021-05-11).I also refactored the
FuturesUnorderedtests a bit. I would have liked to further refactor to have a single function that takes a closure for the way we await on theFuturesUnordered, but async closures are still unstable.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.