Fix query parameters in SSDK #449
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
We use APIGateway multi-value query parameters which will always use an array value for query parameters, even if they're specified only once, and even if that single specification does not have a value. Our translation logic from APIG preserves this structure, and since all query parameters can have multiple values, this isn't necessarily wrong. Our handling of query parameters is actually broken in main, but protocol tests don't uncover this due to the logic that generates non-array values for single query parameters. Streamlining our generated requests in protocol tests uncovers this bug, and aligns more closely with how our code runs in the wild.
We use APIGateway multi-value query parameters which will always use an array value for query parameters, even if they're specified only once, and even if that single specification does not have a value. This changes our logic to not reject an array with a single value when parsing the value for a scalar-bound query parameter, which fixes our handling of query parameters.
JordonPhillips
approved these changes
Oct 11, 2021
trivikr
approved these changes
Oct 13, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
Query parameters in protocol tests were being generated in a way that did not match how our APIGateway integration code would present them to our generated code. Query parameters are actually broken right now, but protocol tests do not detect this. These commits align our protocol test generation to how APIGateway treats query parameter values, and fixes code generation to handle them appropriately.
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.