Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix query parameters in SSDK #449

Merged
merged 2 commits into from
Oct 13, 2021
Merged

Fix query parameters in SSDK #449

merged 2 commits into from
Oct 13, 2021

Commits on Oct 9, 2021

  1. Align protocol test query param logic with APIG behavior 

    We use APIGateway multi-value query parameters which will always use an array
value for query parameters, even if they're specified only once, and even if
that single specification does not have a value. Our translation logic from
APIG preserves this structure, and since all query parameters can have multiple
values, this isn't necessarily wrong. Our handling of query parameters is
actually broken in main, but protocol tests don't uncover this due to the logic
that generates non-array values for single query parameters. Streamlining our
generated requests in protocol tests uncovers this bug, and aligns more closely
with how our code runs in the wild.
    @adamthom-amzn
    adamthom-amzn committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    15bd44f View commit details
    Browse the repository at this point in the history

  2. Handle multi-value query parameters appropriately 

    We use APIGateway multi-value query parameters which will always use an array
value for query parameters, even if they're specified only once, and even if
that single specification does not have a value. This changes our logic to
not reject an array with a single value when parsing the value for a
scalar-bound query parameter, which fixes our handling of query parameters.
    @adamthom-amzn
    adamthom-amzn committed Oct 9, 2021
    Configuration menu
    Copy the full SHA
    9ce3069 View commit details
    Browse the repository at this point in the history