Rework the httpChecksum trait
#972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trait to follow the new design. Removes stale code and updates implementation, tests and documentation
Moves httpChecksum trait to aws.protocols namespace. Updates the trait to follow the new design. Removes stale code and updates implementation, test, and documentation.
kstich
force-pushed
the
aws-protocol_checksum-trait
branch
from
52c3665 to
19c671a
Compare
mtdowling
requested changes
Nov 10, 2021
kstich
force-pushed
the
aws-protocol_checksum-trait
branch
from
19c671a to
4e97243
Compare
mtdowling
reviewed
Nov 10, 2021
kstich
force-pushed
the
aws-protocol_checksum-trait
branch
from
4e97243 to
992e3d5
Compare
This commit updates the httpChecksum trait and behavioral specification for clients and services that use it. It constrains the properties of the trait further, including which checksum algorithms are supported. Validation has been updated to accound for this and other new behavior.
kstich
force-pushed
the
aws-protocol_checksum-trait
branch
from
992e3d5 to
2d7cc17
Compare
mtdowling
approved these changes
Nov 10, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Moves the httpChecksum trait to the
aws.protocolsnamespace and updates the traitto follow a new design that constrains the trait for client safety and forwards compatibility.
A fully updated behavioral specification is included along with the trait specification.
The PR is and support for CORS for API Gateway will be a follow item.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.