[Breaking] Moves httpChecksum trait to aws.protocols namespace.
#938
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…trait to follow the new design. Removes stale code and updates implementation, tests and documentation
mtdowling
requested changes
Oct 15, 2021
.../src/main/java/software/amazon/smithy/openapi/fromsmithy/protocols/AbstractRestProtocol.java
Show resolved
Hide resolved
| HttpChecksumTrait trait = operationShape.expectTrait(HttpChecksumTrait.class); | ||
| headers.addAll(getChecksumHeaders(trait.getRequestProperties())); | ||
| } else if (operationShape.hasTrait(HttpChecksumRequiredTrait.class)) { | ||
| if (operationShape.hasTrait(HttpChecksumRequiredTrait.class)) { |
There was a problem hiding this comment.
Isn't this more nuanced? Don't we need to inject all of the x-amz-checksum-* headers here? And isn't httpChecksumRequired deprecated now?
There was a problem hiding this comment.
The new x-amz-checksum-* headers should be applied in smithy-aws-apigateway-openapi
smithy-aws-traits/src/test/java/software/amazon/smithy/aws/traits/HttpChecksumTraitTest.java
Show resolved
Hide resolved
...s/src/test/resources/software/amazon/smithy/aws/traits/errorfiles/http-checksum-trait.errors
Show resolved
Hide resolved
...s/src/test/resources/software/amazon/smithy/aws/traits/errorfiles/http-checksum-trait.errors
Show resolved
Hide resolved
kstich
requested changes
Oct 28, 2021
| HttpChecksumTrait trait = operationShape.expectTrait(HttpChecksumTrait.class); | ||
| headers.addAll(getChecksumHeaders(trait.getRequestProperties())); | ||
| } else if (operationShape.hasTrait(HttpChecksumRequiredTrait.class)) { | ||
| if (operationShape.hasTrait(HttpChecksumRequiredTrait.class)) { |
There was a problem hiding this comment.
The new x-amz-checksum-* headers should be applied in smithy-aws-apigateway-openapi
...its/src/test/resources/software/amazon/smithy/aws/traits/errorfiles/http-checksum-trait.json
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTrait.java
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTrait.java
Show resolved
Hide resolved
smithy-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTrait.java
Show resolved
Hide resolved
...y-aws-traits/src/main/java/software/amazon/smithy/aws/traits/HttpChecksumTraitValidator.java
Show resolved
Hide resolved
|
Closing in favor of #972 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes:
httpChecksumtrait to follow the revised design.aws.protocols#httpChecksumnamespace.smithy.api#httpChecksum.By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.