Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix daemon startup latency issue by providing an option to skip snaps… #1279

Merged
merged 1 commit into from
Jun 19, 2024

Conversation

Shubhranshu153
Copy link
Contributor

…hotter supported flag

Issue #, if available:
Soci Daemon startup time was long when undergoing simultaneous intense io operations.

Description of changes:
Add a config option to skip snapshotter is supported check that an user can configure

Testing performed:

  1. Test with no option provided in config.toml. This is the default case. There is no change in behaviour
  2. Test with option true in config.toml
Jun 19 17:05:40 ip-172-31-24-167 soci-snapshotter-grpc[9163]: {"level":"info","msg":"starting soci-snapshotter-grpc","revision":"944f0361363540379f0872eb6d93f49e4365ec66.m","time":"2024-06-19T17:05:40.090552376Z","version":"944f036.m"}
Jun 19 17:05:40 ip-172-31-24-167 soci-snapshotter-grpc[9163]: {"level":"warning","msg":"Skipped snapshotter is supported check ","revision":"944f0361363540379f0872eb6d93f49e4365ec66.m","time":"2024-06-19T17:05:40.090751222Z","version":"944f036.m"}
Jun 19 17:05:40 ip-172-31-24-167 soci-snapshotter-grpc[9163]: {"emitMetricPeriod":10000000000,"fetchPeriod":500000000,"level":"info","maxQueueSize":100,"msg":"constructing background fetcher","silencePeriod":30000000000,"time":"2024-06-19T17:05:40.091041601Z"}
Jun 19 17:05:40 ip-172-31-24-167 soci-snapshotter-grpc[9163]: {"address":"/run/soci-snapshotter-grpc/soci-snapshotter-grpc.sock","level":"info","msg":"soci-snapshotter-grpc successfully started","time":"2024-06-19T17:05:40.091712667Z"}
Jun 19 17:05:40 ip-172-31-24-167 systemd[1]: Started soci-snapshotter.service - soci snapshotter containerd plugin.

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@Shubhranshu153 Shubhranshu153 requested a review from a team as a code owner June 19, 2024 17:22
@github-actions github-actions bot added the go Pull requests that update Go code label Jun 19, 2024
Copy link
Contributor

@sondavidb sondavidb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we also update config/config.toml with this new config variable?

We may also want to add an integration test with this config option.

cmd/soci-snapshotter-grpc/main.go Outdated Show resolved Hide resolved
config/fs.go Outdated Show resolved Hide resolved
docs/config.md Outdated Show resolved Hide resolved
cmd/soci-snapshotter-grpc/main.go Outdated Show resolved Hide resolved
…hotter supported flag

Signed-off-by: Shubharanshu Mahapatra <shubhum@amazon.com>
@sondavidb sondavidb merged commit 07296f9 into awslabs:main Jun 19, 2024
10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
go Pull requests that update Go code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants