Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add separate DCO workflow #720

Merged
merged 1 commit into from
Jul 12, 2023
Merged

Add separate DCO workflow #720

merged 1 commit into from
Jul 12, 2023

Conversation

coderbirju
Copy link
Contributor

@coderbirju coderbirju commented Jul 10, 2023 •
edited
Loading

This commit adds a new workflow called 'prebuild' which contains the DCO and lint checks. The Dco check needs to run on every code change regardless of whether it is a documentation or code change hence seperating it out into a different workflow, this will run for all pull and merge requests

Issue #, if available:

Description of changes:

Testing performed:

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@coderbirju coderbirju marked this pull request as ready for review July 10, 2023 19:45
@coderbirju coderbirju requested a review from a team as a code owner July 10, 2023 19:45
@sparr
Copy link
Contributor

sparr commented Jul 11, 2023

This appears to be a partial duplicate (but not quite the requested split) of #713

@coderbirju
Copy link
Contributor Author

This appears to be a partial duplicate (but not quite the requested split) of #713

Would removing the benchmark job from build.yml be a better split?

@turan18
Copy link
Contributor

turan18 commented Jul 11, 2023

Would removing the benchmark job from build.yml be a better split?

Yeah, I think the DCO change should be it's own PR and we can have the benchmarking automation change be separate from this.

@coderbirju
Add a new workflow to separate dco check
f84076c 
The Dco check needs to run on every code change regardless of whether it is a
documentation or code change hence seperating it out into a different
workflow.

Signed-off-by: Arjun Raja Yogidas <arjunry@amazon.com>
@coderbirju
Copy link
Contributor Author

Would removing the benchmark job from build.yml be a better split?

Yeah, I think the DCO change should be it's own PR and we can have the benchmarking automation change be separate from this.

Understood. Updated

@coderbirju coderbirju closed this Jul 11, 2023
@coderbirju coderbirju reopened this Jul 11, 2023
@sparr
Copy link
Contributor

sparr commented Jul 12, 2023

The two PRs still have the same title and substantially similar descriptions, could you update them to describe the contents?

@coderbirju
Copy link
Contributor Author

The two PRs still have the same title and substantially similar descriptions, could you update them to describe the contents?

I have updated the title of the other PR to reflect the changes, also updated the description of this PR

@coderbirju coderbirju changed the title Add new workflow and separate DCO check Add new workflow to separate DCO check Jul 12, 2023
@coderbirju coderbirju changed the title Add new workflow to separate DCO check Add separate DCO workflow Jul 12, 2023
@Kern-- Kern-- merged commit d06927a into awslabs:main Jul 12, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kern-- Kern-- Kern-- approved these changes

@turan18 turan18 turan18 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@coderbirju @sparr @turan18 @Kern--