Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pull] main from grimme-lab:main #251

Merged
merged 2 commits into from
Feb 12, 2025
Merged

[pull] main from grimme-lab:main #251

merged 2 commits into from
Feb 12, 2025

Conversation

pull[bot]
Copy link

@pull pull bot commented Feb 12, 2025

See Commits and Changes for more details.


Created by pull[bot] (v2.0.0-alpha.1)

Can you help keep this open source service alive? 💖 Please sponsor : )

foxtran and others added 2 commits February 12, 2025 08:23
* Use atom fixation during projection

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Number of zeroed frequencies may exceed 6 (up to 3*mol%n) and therefore izero should be adjusted respectfully

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Zero initialization of temporary variables

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Do not override already fixed degrees of freedom

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Properly set indx variable to determine free and fixed atoms

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

---------

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>
Co-authored-by: Sebastian Ehlert <28669218+awvwgk@users.noreply.github.com>
* Skip i==j for avoiding division by zero

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Skip close atoms for avoiding division by zero as well as avoid complex type transformations

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Close files properly

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Cycle after filling gab1/gab2

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Avoid division by zero by updating expression

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

* Use r2 instead of r*r

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>

---------

Signed-off-by: Igor S. Gerasimov <i.s.ger@ya.ru>
@pull pull bot added the ⤵️ pull label Feb 12, 2025
@pull pull bot merged commit 8066e56 into awvwgk:main Feb 12, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant