Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

axa-footer broken when versioned: re-slotting of nested children refers to unversioned component name #2452

Closed
markus-walther opened this issue Aug 28, 2023 · 0 comments · Fixed by #2453
Labels
Accepted A feature request or issue is accepted and will be implemented Bug

Comments

@markus-walther
Copy link
Contributor

<axa-footer> takes slotted light-DOM children for SEO reasons.

To cater for usage scenarios where those children are not direct descendants of <axa-footer>, but rather nested under some other HTML tag(s), an internal function re-slots them to be direct descendants.

A parent-chasing loop terminates when the host element <axa-footer> itself is reached.

This fails for versioned <axa-footer-aem> and similar, because comparison in the loop condition is against the unversioned class tag name 'AXA-FOOTER'.

Fix this bug.

@markus-walther markus-walther added Bug Accepted A feature request or issue is accepted and will be implemented labels Aug 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Accepted A feature request or issue is accepted and will be implemented Bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant