Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix broken axa-footer when versioned #2453

Merged
merged 5 commits into from
Dec 4, 2023
Merged

fix: fix broken axa-footer when versioned #2453

merged 5 commits into from
Dec 4, 2023

Conversation

markus-walther
Copy link
Contributor

@markus-walther markus-walther commented Aug 28, 2023 •
edited
Loading

Fixes #2452

Merge Checklist:

  • Code selfreview has been performed (Best Practices).
  • Tests are sufficient.
  • Documentation is up to date.
  • Changelog is up to date.
  • Typescript typings for properties are up to date.
  • Designers approved changes or no approval needed.
  • Dependencies to other components still work.

@markus-walther markus-walther self-assigned this Aug 28, 2023
@markus-walther markus-walther requested a review from MKaHead August 28, 2023 17:13
@markus-walther markus-walther requested a review from amir-ag August 29, 2023 14:52
@markus-walther markus-walther merged commit 2b084d7 into develop Dec 4, 2023
1 check passed
@markus-walther markus-walther deleted the bugfix/GITHUB-2452-axa-footer-broken-when-versioned branch December 4, 2023 13:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MKaHead MKaHead Awaiting requested review from MKaHead

@amir-ag amir-ag Awaiting requested review from amir-ag

Assignees

@markus-walther markus-walther

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

axa-footer broken when versioned: re-slotting of nested children refers to unversioned component name
1 participant
@markus-walther