-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add live testnet testing instructions to readme #242
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
deanamiel
requested review from
fish-sammy,
re1ro,
Foivos and
milapsheth
as code owners
September 7, 2023 00:35
milapsheth
reviewed
Sep 7, 2023
re1ro
approved these changes
Sep 7, 2023
milapsheth
reviewed
Sep 7, 2023
npty
reviewed
Sep 15, 2023
npty
reviewed
Sep 15, 2023
milapsheth
added a commit
that referenced
this pull request
Sep 21, 2023
* feat: improved unit test coverage (#243) * feat: increased unit test coverage * fix: use expectRevert * chore: migrate loading chains info from axelar-chains-config (#244) * chore: migrate loading chains info from axelar-chains-config * chore: import getBytecodeHash from axelar-chains-config * chore: remove axelar-chain-deployments dep * misc --------- Co-authored-by: Milap Sheth <milap@axelar.network> --------- Co-authored-by: Dean Amiel <dean@axelar.network> Co-authored-by: npty <78221556+npty@users.noreply.github.com> Co-authored-by: Milap Sheth <milap@axelar.network> * feat: add live testnet testing instructions to readme (#242) * feat: add live testnet testing instruccions to readme * fix: indentation * fix: spacing * feat: instructions to add new testnet * fix: spacing * fix: spacing * fix: removed sub-bullets * fix: keys.json location * updated gmp sdk dep * updated README * improve readme * add install cmd --------- Co-authored-by: Dean Amiel <dean@axelar.network> Co-authored-by: Milap Sheth <milap@axelar.network> --------- Co-authored-by: Dean <deanamiel1@gmail.com> Co-authored-by: Dean Amiel <dean@axelar.network> Co-authored-by: npty <78221556+npty@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added instructions for running tests against live testnets to the readme