Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add rpc test to match logIndex #284

Merged
merged 5 commits into from
Jul 23, 2024
Merged

feat: add rpc test to match logIndex #284

Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
d066adc
chore: add test to match logIndex
blockchainguyy Jul 22, 2024
c2a634c
chore: update test
blockchainguyy Jul 22, 2024
8a07847
chore: lint
blockchainguyy Jul 22, 2024
0e100b1
chore: update test to use existing function
blockchainguyy Jul 23, 2024
547ce5c
Update test name
blockchainguyy Jul 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
29 changes: 28 additions & 1 deletion test/RpcCompatibility.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,7 @@
const chai = require('chai');
const { ethers, network } = require('hardhat');
const {
utils: { hexValue, getAddress, keccak256 },
utils: { hexValue, getAddress, keccak256, id },
Wallet,
BigNumber,
} = ethers;
Expand Down Expand Up @@ -384,6 +384,33 @@ describe('RpcCompatibility', () => {
});
});

it('should return consistent logIndex values between eth_getLogs and eth_getTransactionReceipt', async () => {
const amount = 100;

const receipt = await rpcCompatibilityContract.updateValue(amount).then((tx) => tx.wait());
const logsFromReceipt = receipt.logs;

const eventSignature = id('ValueUpdated(uint256)');
const expectedEvent = logsFromReceipt.find((log) => log.topics[0] === eventSignature);
expect(expectedEvent, 'ValueUpdated event not found in logs from tx receipt').to.exist.and.to.not.be.null;

const blockNumber = '0x' + parseInt(receipt.blockNumber).toString(16);
const logsFromGetLogs = await provider.send('eth_getLogs', [
{
fromBlock: blockNumber,
toBlock: blockNumber,
},
]);

const matchingEvent = logsFromGetLogs.find((log) => log.topics[0] === eventSignature);
expect(matchingEvent, 'ValueUpdated event not found in logs from eth_getLogs').to.not.be.null;

expect(parseInt(expectedEvent.logIndex)).to.equal(
parseInt(matchingEvent.logIndex),
'Log index mismatch between tx receipt and eth_getLogs',
);
});

describe('eip-1559 supported rpc methods', () => {
if (!isHardhat) {
it('should support RPC method eth_maxPriorityFeePerGas', async () => {
Expand Down
Loading