feat: Inbound Transaction Verification #785
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
benjamin852
changed the title
|
@benjamin852 can you be clear with the state of this PR? I saw code pushed, but is it finished, are all comments addressed? Any desired eng reviews complete? |
I don't see any comments here that need to be addressed? |
| @@ -13,6 +13,11 @@ With GMP, you can: | |||
| **NOTE:** The security of your contracts is limited to the security of the chains they integrate with. Since blockchains can have different security practices, we recommend doing due diligence on all chains your contract will be deployed to. | |||
| </Callout> | |||
|
|
|||
| <Callout emoji="🚨"> | |||
| **NOTE:** GMP Transactions using `callContractWithToken` sent to the Axelar chain itself are not yet supported. Axelar only supports GMP call without token from Axelar to chain X. Transactions sent to the Axelar chain as the destination chain will be stuck until support is rolled out. | |||
There was a problem hiding this comment.
Are we planning on supporting this? I thought this wasn't part of our architecture?
Chain x I think you need to be more specific, like "supported chains" or something? We don't support any GMP from or to Axelar. (Axelar is not a supported GMP chain, right?).
There was a problem hiding this comment.
It's a feature the team wants to add
| 3. `SourceAddress`: The source address of the contract call | ||
| 4. `PayloadHash`: A hash of the GMP message that was sent with the call | ||
|
|
||
| Using this information it verifies that the inbound call has indeed been verified by the Axelar network and that this data is the authentic data passed in from the source chain rather than a malicious execution with invalid data on the destination chain. |
There was a problem hiding this comment.
"verifies it has indeed been verified" language is a little unclear cc @ffe9f8
…eaxelar are initiated via gateway
StephenFluin
force-pushed
the
ben/tx-verification
branch
from
e0d5c22
to
2788647
Compare
@milapsheth if you have time feel free to review the cosmos gmp verification to ensure it's accurate. Thanks