Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FeatureRequest] Tool types can be named anything #109

Closed
vezdeneszter opened this issue Oct 2, 2023 · 7 comments
Closed

[FeatureRequest] Tool types can be named anything #109

vezdeneszter opened this issue Oct 2, 2023 · 7 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue to help with during Hacktoberfest2023

Comments

@vezdeneszter
Copy link
Contributor

Currently, when the user creates a new Dev Env, they can only select from the “supported” tool types. The DEM doesn’t accept any Dev Env descriptor that is not included in the supported tool type list.

This behavior should be changed because it limits the usability for no reason.

The DEM should not check whether the tool type is supported or not. Any name can be given for a tool type.

The “supported” tool types are stored in the DevEnv class’s supported_tool_types class variable.

@vezdeneszter vezdeneszter added the enhancement New feature or request label Oct 2, 2023
@vezdeneszter vezdeneszter added the hacktoberfest Issue to help with during Hacktoberfest2023 label Oct 2, 2023
@janosmurai janosmurai added the good first issue Good for newcomers label Oct 2, 2023
@vezdeneszter vezdeneszter moved this to 🔖 Ready to implement in DEM Open Oct 2, 2023
@officialasishkumar
Copy link
Contributor

Hi @vezdeneszter,

Do you want me to just ask for the name of the tool type?

@janosmurai
Copy link
Contributor

No, the only task is to remove the _check_tool_type_support() method from the DevEnv class.
(The supported_tool_types class variable is still needed for the TUI, so don't delete that one.)

Please tell us if you'd like to start working on an issue, so we can assign it to you! Thanks!

@amathestar
Copy link

Hi @janosmurai, is this task still open? I would like to work on it

@janosmurai
Copy link
Contributor

Hello @amathestar
Yes, it is still open. I'll assign it to you.

@amathestar
Copy link

Hi @janosmurai, seem to be struggling with the pytest after removing the _check_tool_type_support() method. Can I get some assistance?

@janosmurai
Copy link
Contributor

Hey @amathestar
Sure thing, let's discuss it on Discord!

@janosmurai
Copy link
Contributor

Hey @amathestar
Are you still working on this issue? Tell me if you need any help!

@janosmurai janosmurai mentioned this issue Dec 8, 2023
9 tasks
@github-project-automation github-project-automation bot moved this from 🔖 Ready to implement to ✅ Done in DEM Open Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers hacktoberfest Issue to help with during Hacktoberfest2023
Projects
Status: ✅ Done
Development

No branches or pull requests

4 participants