Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Accept any tool type. #147

Merged
merged 1 commit into from
Dec 8, 2023
Merged

Accept any tool type. #147

merged 1 commit into from
Dec 8, 2023

Conversation

janosmurai
Copy link
Contributor

@janosmurai janosmurai commented Dec 8, 2023 •
edited by jira bot
Loading

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Any modification in the test cases
  • Any modification in the documentation

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • All the test cases pass and new modifications in the production code are 100% covered.
  • I have made corresponding changes to the documentation.

Related Issue

Closing:
#109
DEM-201

Description

Instead of based on a fixed list, the tool image types can be named anything.

How Has This Been Tested?

The test cases were updated to reflect this change.

@janosmurai janosmurai requested a review from a team as a code owner December 8, 2023 16:31
@janosmurai
Copy link
Contributor Author

These were originally changes by @amathestar.

@janosmurai janosmurai merged commit dfbd126 into main Dec 8, 2023
1 check passed
@janosmurai janosmurai deleted the 109 branch December 8, 2023 16:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vezdeneszter vezdeneszter Awaiting requested review from vezdeneszter vezdeneszter is a code owner automatically assigned from axem-solutions/persea

@magyta93 magyta93 Awaiting requested review from magyta93 magyta93 is a code owner automatically assigned from axem-solutions/persea

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@janosmurai