Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Communication with DockerHub is changed to use it's API instead of the Docker Engine. #206

Merged
merged 2 commits into from
Aug 28, 2024

Conversation

janosmurai
Copy link
Contributor

@janosmurai janosmurai commented Aug 28, 2024

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Any modification in the test cases
  • Any modification in the documentation

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • All the test cases pass and new modifications in the production code are 100% covered.
  • I have made corresponding changes to the documentation.

Related Issue

Closing:
DEM-284
#203

Description

When obtaining the available repositories in a DockerHub namespace, the Container
Engine's search functionality had been used. This somehow had changed, so
filtering for the namespace didn't work anymore.
The new solution is to use the DockerHub's API directly.

To be able to manage the registries properly the config file got extended so
the registry config has a new field called 'namespace'. This breaks backward
compatibility.

How Has This Been Tested?

Tested on Ubuntu 22.04

@janosmurai janosmurai requested a review from a team as a code owner August 28, 2024 09:45
@janosmurai janosmurai merged commit ebb99c1 into axem-solutions:main Aug 28, 2024
1 check passed
@janosmurai janosmurai deleted the DEM-284 branch August 28, 2024 09:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant