Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🔨 [tuning] Added continuous deployment workflow for PyPI #222

Merged
merged 2 commits into from
Oct 3, 2024

Conversation

hitblast
Copy link
Contributor

@hitblast hitblast commented Oct 2, 2024

Type Of Change

  • New feature (non-breaking change which adds functionality)
  • Bug fix (non-breaking change which fixes an issue)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Any modification in the test cases
  • Any modification in the documentation

Checklist:

  • I have read and followed the contribution guideline.
  • I have checked to ensure there aren't other open Pull Requests for the same update/change.
  • All the test cases pass and new modifications in the production code are 100% covered.
  • I have made corresponding changes to the documentation.

Related Issue

Closing: #221

Description

This PR adds an automation workflow for automatically deploying later versions of DEM to the Python Package Index when a GitHub Release is issues.

How Has This Been Tested?

While building this code, I have tested it on my own Python packages for proof-of-concept.

Additional info

In order for this workflow to work, you'll have to set PYPI_TOKEN as a GitHub Actions Secret inside the DEM repository, and set it to the value which you'll get after generating a token from https://pypi.org/ for the project.

@hitblast hitblast requested a review from a team as a code owner October 2, 2024 10:49
Copy link
Contributor

@janosmurai janosmurai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please just remove the first two lines. The rest lgtm.

Comment on lines 1 to 2
# SPDX-License-Identifier: MIT

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

License information is not needed.

(Btw, DEM is licensed under 'Eclipse Public License - v 2.0')

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@janosmurai Fixed this with the latest commit.

@hitblast
Copy link
Contributor Author

hitblast commented Oct 3, 2024

Please just remove the first two lines. The rest lgtm.

@janosmurai Removed. Check now I guess if it meets the requirements?

@janosmurai janosmurai added the hacktoberfest-accepted Accepted during hacktoberfest label Oct 3, 2024
@janosmurai janosmurai merged commit f4f876f into axem-solutions:main Oct 3, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
hacktoberfest-accepted Accepted during hacktoberfest
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants