We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ronin-dpos-contracts/contracts/ronin/Maintenance.sol
Line 142 in 2ef51c7
Note: same for `bulkMaintaining`
Naming: confusing names
As stated in the comment of scheduled, the checking must be done in range of blocks, not just by a timestamp indicated by a single block.
scheduled
Originally posted by @nxqbao in #22 (comment)
The text was updated successfully, but these errors were encountered:
I think should add is/bulkIs prefix to view methods that returns bool/bool[] for clarity. Adding them also partially solves #69.
is/bulkIs
bool/bool[]
Sorry, something went wrong.
The pattern bulk + function name should work fine for the mutable functions, but for the view functions, we can workaround by renaming them, e.g:
bulk + function name
jailed
getJailedStatus
getJailedStatuses
stakingAmountOf
getStakingAmount
getStakingAmounts
Successfully merging a pull request may close this issue.
ronin-dpos-contracts/contracts/ronin/Maintenance.sol
Line 142 in 2ef51c7
Naming: confusing names
As stated in the comment of
scheduled
, the checking must be done in range of blocks, not just by a timestamp indicated by a single block.Originally posted by @nxqbao in #22 (comment)
The text was updated successfully, but these errors were encountered: