Internal Audit #22
Closed
Internal Audit #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minh-bq
reviewed
Nov 1, 2022
minh-bq
reviewed
Nov 1, 2022
| import "../../precompile-usages/PrecompileUsagePickValidatorSet.sol"; | ||
| import "./CandidateManager.sol"; | ||
|
|
||
| contract RoninValidatorSet is |
There was a problem hiding this comment.
Should this contract support withdraw function to withdraw jailed reward?
minh-bq
reviewed
Nov 2, 2022
* Add draft contract for credit score and bail out * Fix maintenance at current period * Update comment * Fix check in maintainingAtCurrentPeriod * Replace maintainingAtCurrentPeriod by maintainingInBlockRange * Refactor credit score to an abstract contract * Fix bailout function * Refactor test for slash * Fix contract * Refactor slash indicator test * Add first test * Fix fixture id * Add more test for credit score * Fix contracts * Fix test helper. Add more tests. * Add jailedAtBlock methods * Fix test * Fix rebase error. Update contracts. * Fix contracts * Fix credit score test * Fix test * Refactor _setUnavailabilityIndicator method * Change fixture name * Fix docs * Add gap for CreditScore contract * Mark helper contracts of SlashIndicator as abstract * Refactor slash indicator interfaces * Update contracts/interfaces/slash-indicator/ICreditScore.sol Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * Update contracts/interfaces/slash-indicator/ICreditScore.sol Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * Update test/helpers/ronin-validator-set.ts Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * Update contracts/libraries/Math.sol Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * Update contracts/libraries/Math.sol Co-authored-by: Duc Tho Tran <ducthotran2010@gmail.com> * Add comments Co-authored-by: nxqbao <quocbao300@gmail.com>
* Merge two bonus requests bonus into one * Rename in tests * Rename deploy scripts * Use unsafeSendRON for staking vesting * Add tests * Fix rebase * Add contract balance for transfer failed event * Handle no request bonus for deprecated block producer
Co-authored-by: Bao <quocbao300@gmail.com>
This was referenced Nov 4, 2022
Closed
Closed
Closed
Closed
* Update reward calculation mechanism * Change balance to stakingAmount * Fix rebase issues * Update pool shares syncing mechanism
This was referenced Nov 7, 2022
|
The discussions put in this PR this quite hard to follow. If any further bugs/issues are found or something you need to discuss please make it an issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Review Progress: