[Staking] Update reward calculation mechanism #44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ducthotran2010
changed the title
ducthotran2010
commented
Nov 3, 2022
minh-bq
reviewed
Nov 7, 2022
| /// @dev Mapping from the pool address => settled pool data | ||
| mapping(address => SettledPool) internal _settledPool; | ||
| /// @dev Mapping from period number => accumulated rewards per share (one unit staking) | ||
| mapping(uint256 => PeriodWrapper) private _accumulatedRps; |
There was a problem hiding this comment.
As far as I understand, this is used to track the rps of pool in period, so this must be per pool and a new pool address dimension is needed.
| uint256 _aRps = _accumulatedRps[_reward.lastPeriod].inner; | ||
| uint256 _lastPeriodReward = _minAmount * (_aRps - _reward.aRps); | ||
| uint256 _newPeriodsReward = _latestStakingAmount * (_pool.aRps - _aRps); | ||
| return _reward.debited + (_lastPeriodReward + _newPeriodsReward) / 1e18; |
There was a problem hiding this comment.
Can we remove 1e18 here and in _recordRewards below?
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
RewardCalculation.sol] Update reward calculation mechanism: Deprecated slashing feature for staking contractRoninValidatorSet.sol] Update staking reward recording: updating rewards at the end of each block -> periodbalancetostakingAmountto avoid misleadingbalanceOf->stakingAmountOf,totalBalance->stakingTotalWhat's to be noticed?
RoninValidatorSet.solRewardCalculation.solRewardCalculation.test.tsChecklist