fix: avoid producing empty block when pending transactions is high #195
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This branch is based on #193 to only support Buba hardfork, this PR is intended to be merged after PR 193 |
minh-bq
force-pushed
the
fix/empty-block
branch
2 times, most recently
from
da8a111 to
cf26e62
Compare
DNK90
approved these changes
Dec 30, 2022
linh-1
approved these changes
Dec 30, 2022
minh-bq
force-pushed
the
fix/empty-block
branch
from
cf26e62 to
b4a2f62
Compare
trantienduchn
approved these changes
Jan 5, 2023
minh-bq
force-pushed
the
fix/empty-block
branch
from
b4a2f62 to
64801e8
Compare
This commit adapts BSC PR: bnb-chain/bsc#112 to Ronin. An empty block is pre-sealed by default. It's expected that a new block with transactions is committed and abort the empty block producer if there are pending transactions. However, with the low block time, in case there are a lot of pending transactions, the commit transactions time exceeds the time an empty block is produced. As a result, block with transactions is not produced but an empty block and no real transactions is mined.
minh-bq
force-pushed
the
fix/empty-block
branch
from
64801e8 to
f74ff9d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit adapts BSC PR: bnb-chain/bsc#112 to Ronin.
An empty block is pre-sealed by default. It's expected that a new block with
transactions is committed and abort the empty block producer if there are
pending transactions. However, with the low block time, in case there are a lot
of pending transactions, the commit transactions time exceeds the time an empty
block is produced. As a result, block with transactions is not produced but an
empty block and no real transactions is mined.