v2/consortium_test: fix: do not insert inserted blocks #612
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Francesco4203
commented
Oct 23, 2024
| } | ||
| if _, err := chain.InsertChain(bs[:], nil); err != nil { | ||
| // only insert newly generated blocks |
There was a problem hiding this comment.
For some reason this still previously passed for Hash Scheme 🤔
andicrypt
reviewed
Oct 24, 2024
| } | ||
| if _, err := chain.InsertChain(bs[:], nil); err != nil { | ||
| // only insert newly generated blocks | ||
| if _, err := chain.InsertChain(newBs[:], nil); err != nil { |
There was a problem hiding this comment.
I think we can remove newBs by only using bs[399:] here
| } | ||
| if _, err := chain.InsertChain(bs[:], nil); err != nil { | ||
| // only insert newly generated blocks | ||
| if _, err := chain.InsertChain(newBs[:], nil); err != nil { |
|
@Francesco4203 so for clear, that the test is failed related to limit of maxdifflayer logic Pathbase, for Hashbase they still look into the keyvalue for checking rootState by Hash?, so could u verify this limit again? after that add comment in the test for clearing why do we choose this number. |
huyngopt1994
deleted the branch
axieinfinity:all-fix-some-bugs-during-testing
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Before this PR, in
TestIsPeriodBlockandTestIsTrippEffective, the chain of blocks is inserted while it still includes some previously inserted blocks, potentially cause the following error when running on path scheme:This PR is to fix it by creating a new list of blocks that only contains newly created blocks.
Run test after fixing: