forked from privacy-scaling-explorations/halo2
-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Release v0.4.0] FFT memory reduction and proving key size reduction #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…tions#77 (#6) * Resolve taikoxyz/zkevm-circuits#77 * Please Clippy
Also fixed some issue when multicore feature is not on.
jonathanpwang
changed the title
[HOLD] [feat] FFT memory reduction and proving key size reduction
[feat] FFT memory reduction and proving key size reduction
Nov 18, 2023
jonathanpwang
changed the title
[feat] FFT memory reduction and proving key size reduction
[Release v0.4.0] FFT memory reduction and proving key size reduction
Nov 18, 2023
CPerezz
added a commit
to privacy-scaling-explorations/halo2
that referenced
this pull request
Feb 7, 2024
This incorporates the work done in scroll-tech#28 in order to lower the memory consumption significantly trading off for some performance. A much more deep analysis can be found here: axiom-crypto#17
CPerezz
added a commit
to privacy-scaling-explorations/halo2
that referenced
this pull request
Feb 26, 2024
This incorporates the work done in scroll-tech#28 in order to lower the memory consumption significantly trading off for some performance. A much more deep analysis can be found here: axiom-crypto#17
CPerezz
added a commit
to privacy-scaling-explorations/halo2
that referenced
this pull request
Mar 2, 2024
This incorporates the work done in scroll-tech#28 in order to lower the memory consumption significantly trading off for some performance. A much more deep analysis can be found here: axiom-crypto#17
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-picked from taikoxyz#6 however the original PR for this is scroll-tech#28
In the process of debugging I also cherry-picked taikoxyz#4 as cleanup.
The proving key size is reduced because the extended Lagrange coefficients of fixed polynomials is not stored in the proving key. However this means this FFT computation is done by the prover. We need to benchmark further to determine whether we want this prover speed tradeoff for the decrease in proving key size and decreased memory usage.
I have also removed the shuffle API because it is not supported by
snark-verifier
.Preliminary benchmark on my laptop:
Using https://github.com/axiom-crypto/halo2-lib/tree/0df530e6e29a591a6c7030953a140163e8991bd3 for keccak shard + aggregation.
On
main
branch without this PR:Using this PR:
Aggregation circuit stats:
We have decided that the reduction in memory bandwidth and proving key size is worth the performance overhead, so this will be merged as
halo2-axiom
releasev0.4.0
.