-
-
Notifications
You must be signed in to change notification settings - Fork 10.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding isAxiosError flag to errors thrown by axios #1419
Conversation
@AyushG3112 Can you resolve conflicts? |
Maybe as well @RikkiGibson and @emilyemorehouse |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, this will ease up correct error detection a lot :)
I resolved the conflict @cruelbob @AyushG3112, overall I agree with this change. I will try to merge asap |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
thx |
Will this enhancement be available in |
Is this |
Adding a
isAxiosError
flag in errors thrown by axios.This PR aims to resolve the issue posed by #1415 while preventing breaking changes.