fix(reactmultiemail): fix copy and paste of multiple emails at a time #147
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
jhaltercmu2020
force-pushed
the
bug/copy-paste-issue
branch
from
9dd4117
to
2c21890
Compare
jhaltercmu2020
commented
Jul 24, 2023
jhaltercmu2020
force-pushed
the
bug/copy-paste-issue
branch
from
2c21890
to
14f273b
Compare
134130
reviewed
Aug 17, 2023
fix copy and paste of multiple emails in a row
jhaltercmu2020
force-pushed
the
bug/copy-paste-issue
branch
from
14f273b
to
6a933d7
Compare
thomasJang
approved these changes
Aug 19, 2023
|
@thomasJang Would you be able to ping a few other maintainers to review this? |
|
@jhaltercmu2020 I am sorry we were late! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes copy and paste for multiple emails in a row. @thomasJang Looks like after a bit more extensive testing, checking
if array.length === 1is not what we want to do. When trying to copy-paste emails copied from Google this check does not work.Sorry for my mistake, can you review and see if I am missing anything? Thanks.