Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add From: to MessageView list #403

Closed
wants to merge 1 commit into from
Closed

Conversation

fasterit
Copy link
Contributor

@fasterit fasterit commented Dec 9, 2024

I found it inconsistent that the From: is shown on the Inbox view but not on the messages view.
Hope this helps others that have a diverse set of senders, too.
/DLange

@axllent
Copy link
Owner

axllent commented Dec 10, 2024

Thank you. Originally I intentionally skipped this to save space and to resemble the mobile view of the "inbox view", however I realise now that I used to To instead of the From.... an oversight on my behalf.

Adding the From here does not actually add that much space, however makes it very difficult to see the difference between the subject line and the From line. I'm wondering is this is maybe not a better (and easier to read) alternative to your proposal?

Screenshot 2024-12-10 at 17-12-05 Mailpit - localhost

What do you think?

@fasterit
Copy link
Contributor Author

I actually like seeing "To:" and "From:".
Visually I like your proposal but may be you can add the "To:" line again below the sender?

@axllent
Copy link
Owner

axllent commented Dec 10, 2024

Do you mean like this?
Screenshot 2024-12-10 at 21-34-29 Mailpit - localhost

@fasterit
Copy link
Contributor Author

Yes, I like that. It seems the most useful way of presenting enough data for an easy overview of the message view.

@axllent
Copy link
Owner

axllent commented Dec 10, 2024

OK cool, I'm happy with that. Please leave this with me as I've already made the changes locally which is quite different to what you have, and I also include a couple of minor changes to the mobile view of the inbox view. I'll push through the update shortly (which will become available in the docker edge build if you're interested after I push the change). Please note that this won't be released for another week or two as I am about to have shoulder surgery, so it will take a bit longer than usual before I release a new version (I just released a version a couple of days ago) 👍

Thanks for the PR though, I do appreciate it even if I'm not merging it in this time!

@fasterit
Copy link
Contributor Author

No worries, we have the "issue" solved with the PR, so take all your time. We'll converge back to upstream once you push your change.
Good luck with the shoulder surgery!
/DLange

@fasterit fasterit closed this Dec 10, 2024
@axllent
Copy link
Owner

axllent commented Dec 10, 2024

Thank you!

@axllent
Copy link
Owner

axllent commented Dec 14, 2024

This has now been released in v1.21.7.

tmeijn pushed a commit to tmeijn/dotfiles that referenced this pull request Dec 20, 2024
This MR contains the following updates:

| Package | Update | Change |
|---|---|---|
| [axllent/mailpit](https://github.com/axllent/mailpit) | patch | `v1.21.6` -> `v1.21.8` |

MR created with the help of [el-capitano/tools/renovate-bot](https://gitlab.com/el-capitano/tools/renovate-bot).

**Proposed changes to behavior should be submitted there as MRs.**

---

### Release Notes

<details>
<summary>axllent/mailpit (axllent/mailpit)</summary>

### [`v1.21.8`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1218)

[Compare Source](axllent/mailpit@v1.21.7...v1.21.8)

##### Chore

-   Update node dependencies
-   Update Go dependencies

##### Fix

-   **db:** Remove unused FOREIGN KEY REFERENCES in message_tags table ([#&#8203;374](axllent/mailpit#374))

### [`v1.21.7`](https://github.com/axllent/mailpit/blob/HEAD/CHANGELOG.md#v1217)

[Compare Source](axllent/mailpit@v1.21.6...v1.21.7)

##### Chore

-   Update node dependencies
-   Update Go dependencies
-   Bump Go version for automated testing
-   Move smtpd & pop3 modules to internal
-   Stricter SMTP 'MAIL FROM' & 'RCPT TO' handling ([#&#8203;409](axllent/mailpit#409))
-   Display "To" details in mobile messages list
-   Display "From" details in message sidebar (desktop) ([#&#8203;403](axllent/mailpit#403))

##### Fix

-   Ignore unsupported optional SMTP 'MAIL FROM' parameters ([#&#8203;407](axllent/mailpit#407))
-   Prevent splitting multi-byte characters in message snippets ([#&#8203;404](axllent/mailpit#404))

##### Testing

-   Add smtpd tests

</details>

---

### Configuration

📅 **Schedule**: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).

🚦 **Automerge**: Disabled by config. Please merge this manually once you are satisfied.

♻ **Rebasing**: Whenever MR becomes conflicted, or you tick the rebase/retry checkbox.

🔕 **Ignore**: Close this MR and you won't be reminded about this update again.

---

 - [ ] <!-- rebase-check -->If you want to rebase/retry this MR, check this box

---

This MR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate).
<!--renovate-debug:eyJjcmVhdGVkSW5WZXIiOiIzOS42NC4wIiwidXBkYXRlZEluVmVyIjoiMzkuNzUuMCIsInRhcmdldEJyYW5jaCI6Im1haW4iLCJsYWJlbHMiOlsiUmVub3ZhdGUgQm90Il19-->
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants