Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Allow setting certain defines without modifying engine source #1710

Merged
merged 1 commit into from
Feb 21, 2024

Conversation

rh101
Copy link
Contributor

@rh101 rh101 commented Feb 21, 2024

Describe your changes

Allow a game project to define the values of AX_ENABLE_CACHE_TEXTURE_DATA and AX_ENABLE_RESTART_APPLICATION_ON_CONTEXT_LOST without having to modify the engine source code.

For example, this may be done via cmake, prior to the include(AXBuildSet) line:

if(ANDROID)
    add_definitions(-DAX_ENABLE_CACHE_TEXTURE_DATA=0 -DAX_ENABLE_RESTART_APPLICATION_ON_CONTEXT_LOST=1)
endif()

Issue ticket number and link

#1211 (comment)

Checklist before requesting a review

For each PR

  • Add Copyright if it missed:
    - "Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."

  • I have performed a self-review of my code.

    Optional:

    • I have checked readme and add important infos to this PR.
    • I have added/adapted some tests too.

For core/new feature PR

  • I have checked readme and add important infos to this PR.
  • I have added thorough tests.

@halx99 halx99 added this to the 2.1.2 milestone Feb 21, 2024
@halx99 halx99 added the enhancement New feature or request label Feb 21, 2024
@halx99 halx99 merged commit 184e0dc into axmolengine:dev Feb 21, 2024
9 checks passed
@rh101 rh101 deleted the android-context-lost-defines branch February 21, 2024 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants