Remove box2d-optimized #1913
Merged
Remove box2d-optimized #1913
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Removed Box2D-optimized This project is now obsolete; Erin Catto has developed Box2D v3 with many performance improvements, so please use that instead
|
shoud we also need remove box2d-optimized from 3rdparty? |
|
Also CMakeLists: https://github.com/axmolengine/axmol/blob/dev/3rdparty/CMakeLists.txt#L4 opiton and relatived code And here: https://github.com/axmolengine/axmol/blob/dev/README_CN.md?plain=1#L85 |
|
@halx99 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed Box2D-optimized
This project is now obsolete;
Erin Catto has developed Box2D v3 with many performance improvements, so please use that instead
Describe your changes
Issue ticket number and link
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR