Apply child stencils correctly to the clipping node #1957
Merged
+157
−9
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix incorrect reference count for original program states stored in collection
rh101
changed the title
rh101
changed the title
|
Please add a new test to cpp_test too. |
Test added. Output should be the following: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix incorrect reference count for original program states stored in collection
Describe your changes
When using different child stencils in a
ClippingNode, theProgramStateapplied to each child was exactly the same, resulting in incorrect output.With this change, it now allows the developer to set whether the
ClippingNodeuses the same uniqueProgramStateper child stencil.An existing issue is also fixed, due to the
_originalStencilProgramStatecollection not retaining theProgramStateinstances saved in it. These instances were being released by the parent node after being added to the_originalStencilProgramState, which meant that they may have been freed if their reference count became 0. The change in this PR ensures that they are correctly retained prior to being added to the collection.This change will not affect existing usage, as the new functionality is optional.
Issue ticket number and link
#1956
Checklist before requesting a review
For each PR
Add Copyright if it missed:
-
"Copyright (c) 2019-present Axmol Engine contributors (see AUTHORS.md)."I have performed a self-review of my code.
Optional:
For core/new feature PR