Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Questions re: DRF renderer_classes #28

Closed
beaugunderson opened this issue Dec 25, 2017 · 2 comments
Closed

Questions re: DRF renderer_classes #28

beaugunderson opened this issue Dec 25, 2017 · 2 comments
Assignees
Milestone

Comments

@beaugunderson
Copy link
Contributor

We use djangorestframework-camel-case and set our views' renderer_classes to CamelCaseJSONRenderer.

Because of this our Swagger/OpenAPI output differs from the actual output; a field specified as staff_member is represented as staffMember in the view output but incorrectly as staff_member in the Swagger output.

What's the best way to remedy this, and are you interested in remedying it within this project? (If not, I could always post-process the output myself).

@axnsan12
Copy link
Owner

Hello,

I have also been thinking about custom renderers and CamelCaseJSONRenderer specifically, and I haven't yet found a clean way to handle them. I do however think that camel cased input/output is a useful and common enough case that it would be worth providing a built-in integration.

I will look into this for 1.1.

@axnsan12 axnsan12 self-assigned this Dec 25, 2017
@axnsan12 axnsan12 added this to the 1.1.x milestone Dec 25, 2017
axnsan12 added a commit that referenced this issue Dec 26, 2017
@axnsan12
Copy link
Owner

Implemented in #30.

Should work in 1.1.0 which is now on pypi.

PaulWay pushed a commit to PaulWay/drf-yasg that referenced this issue Oct 18, 2020
* Add sample code to handle Base64 fields in drf-extra-fields project

* Fix format for .rst

* Update Redoc to 2.0.0-rc36

* Update answer to the easier version as suggested in Hipo/drf-extra-fields#66 (comment)

* Fix tox environment to properly test on Django 3.0

* Drop all compat support to Django < 2 urls

* Fix tox environment

* Update manifest

* Populate test db

* Fix broken URLs in README

* Feature/update travis (axnsan12#17)

* Redefine travis steps to include linting

* Add stage specific install scripts

* Add docs and publish requirements

* Update travis.yml requirements

* Update travis pip executable

* Update flake8 ignore rules and rever pip3 to pip

* Separate deploy stage in travis

* Add tox dependency to test.txt

* Bump drf test targets

* Allow test against latest deps to fail

* Set build matrix against unittest task only

* Remove matrix key from travis.yml

* Use aliases to specify matrix style parallelism for unittests only

* Write tox-filter.sh

* Move linting and formatting conf into their scripts

* Run black and autoflake (axnsan12#18)

* Fix documentation build (axnsan12#12)

* Fix malformed RST in README

* Fix Sphinx configuration

Co-authored-by: JoelLefkowitz <45922542+JoelLefkowitz@users.noreply.github.com>

* Move dependencies to setup.py and metadata to setup.cfg (axnsan12#19)

* Remove requirements, update .gitignore and remove flake8-isort (axnsan12#20)

* Remove requirements, update .gitignore and remove flake8-isort from linting spec

* Patch test[s] typo

* Fix lint build and set as required on Travis (axnsan12#22)

Co-authored-by: johnthagen <johnthagen@gmail.com>

* Feature/remove clutter (axnsan12#21)

* Remove requirements, update .gitignore and remove flake8-isort from linting spec

* Patch test[s] typo

* Patch setup.py test requirements missing comma typo

* Replace pyproject.toml

* Update pyproject.toml

* Update and convert readme and license to md (axnsan12#25)

* Remove compat.py typo (axnsan12#26)

* Update license references to md

* Update python2.7 compatability test suite

* Pass sphinx build warnings

* Add bumbpversion.cfg and refactor dry-yasg2 to drf_yasg2

* Remove tox check

* Debump django dependency so that py27 tests can setup

* Update travis test-docs script path

* Add build shield to readme

* Debump pytest dep for python2.7 tests

* Debump djangorestframework-camel-case dep for python2.7 tests

* Debump django-cors-headers dep for python2.7 tests

* Remove swagger-spec-validator dep for python2.7 tests

* Update readme links and add python2.7 classifier

* Add dj_database_url heroku dependency

Co-authored-by: Terry <wasin.th@gmail.com>
Co-authored-by: Julia Nething <julia.nething@mobilityhouse.com>
Co-authored-by: johnthagen <johnthagen@users.noreply.github.com>
Co-authored-by: Fasih Ahmad Fakhri <fasih@email.com>
Co-authored-by: johnthagen <johnthagen@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants