swagger_extra_fields should be allowed even when we don't call get_schema #142
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It appears that it is possible to write a Schema Definition for use with a SchemaRef without creating the object through
get_schema
. The side effect of this is that if you have specifiedschema_extra_fields
with parameters you care about (such as examples) they never get set.This patch adds support for custom fields even when building a SchemaRef because it is possible for
field_to_swagger_object
to get called without callingget_schema
. The below example illustrates a case where this happens.Example:
Without the patch, this will omit the
example
additional field. With the patch, it won't.