fix Optional typing hint for SerializerMethodField #428
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The test breaks Python 2.7 compatibility, I'll try to fix it. |
etene
force-pushed
the
fix-optional-type-hint
branch
from
0cd9246 to
af05f22
Compare
etene
force-pushed
the
fix-optional-type-hint
branch
from
af05f22 to
d7a81b1
Compare
beaugunderson
approved these changes
Sep 4, 2019
|
is it going to be merged? I have the same issue |
|
Seems good, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hello,
As reported in #426, commit 69b628a broke type hinting for
SerializerMethodFieldreturn values.Here is a fix`that reverts two lines that I believe should not have been removed, and adds a test to ensure it won't break again.
I only tested with 3.7 on my machine, I hope it doesn't break anything for other Python versions.