Default to "/accounts/logout/" rather than settings.LOGOUT_URL #646
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
settings.LOGOUT_URL hasn't been included in Django since Django 1.10, and hasn't functioned since pre-1.0. The default of "/accounts/logout/" corresponds to most examples in the documentation, and is more likely to work out of the box than the present default of `None`. See django/django@59f861f
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
settings.LOGOUT_URL hasn't been included in Django since Django 1.10,
and hasn't functioned since pre-1.0.
The default of "/accounts/logout/" corresponds to most examples in the
documentation, and is more likely to work out of the box than the
present default of
None.See django/django@59f861f