Add checker for allow_null attr #688
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Check for allow_null attribute
d3QUone
reviewed
Jan 9, 2021
src/drf_yasg/inspectors/base.py
Outdated
| instance_kwargs['x_nullable'] = True | ||
|
|
||
| if hasattr(field, 'allow_null'): | ||
| if field.allow_null: |
There was a problem hiding this comment.
you can simplify these two ifs:
if getattr(field, 'allow_null', None):
instance_kwargs['x_nullable'] = True
|
Please merge this 👍 it's basically not usable with Serpy Serializers. #687 |
|
Hey, would it be possible to merge this pull request or are there any other issues that need to be fixed? |
|
@d3QUone Can we get this merged? My code can't pass OpenAPI2.0 without it |
d3QUone
approved these changes
Sep 8, 2021
|
I think yes, it's fine. But only project collaborators have access to merge.. |
|
Hi It's still pending to merge @krectra could you take a look at it!. Thanks |
Pending workflow approval |
JoelLefkowitz
added
bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes for error occurring on serpy serializers