-
Notifications
You must be signed in to change notification settings - Fork 440
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix: Provide support for enums in codecs. #837
Conversation
I decided to immediately add tests for Python 3.11. |
290c26f
to
1b2d89c
Compare
@JoelLefkowitz The project needs a goooood refactoring... )) |
@JoelLefkowitz ping |
Hey @onegreyonewhite, looks like unit tests failed for the python3.8, fancy having a look? |
It was not the tests that were broken, but the documentation. I have no idea how it used to work. Perhaps this test was simply not checked before, and I fixed its launch. Take a look. |
@JoelLefkowitz can you approve CI run? |
@JoelLefkowitz I finally found and solved the problem: the old mechanism does not work with the new tox. I think it is necessary to solve the problem of new tox in a separate PR. Please, approve PR and check the code. |
@JoelLefkowitz it becomes to hard to maintain this PR )) Started from enums and ended with refactoring, fixing bugs and CI and added support for feature django version. I fixed dj-master tests. Django master branch bumped minimal python version to Python 3.10. In latest version was added check for uniq basename. That's was fixed and I think it's enough for this PR ;) Please, approve it and release it. |
Django master branch bumped minimal python version to Python 3.10. In latest version was added check for uniq basename.
@onegreyonewhite Thanks for the contribution :) |
Also includes the equivalent changes from my PR for the older #836 so that's been closed now support is being tested :) |
We ran into bugs when using Enum objects in inspectors. Due to this problem, the schema could not be rendered via the generate_swagger command.