Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

make RemoteAsset an optional feature #26

Merged
merged 2 commits into from
Mar 30, 2023
Merged

make RemoteAsset an optional feature #26

merged 2 commits into from
Mar 30, 2023

Conversation

Gankra
Copy link
Contributor

@Gankra Gankra commented Mar 29, 2023

No description provided.

@Gankra
Copy link
Contributor Author

Gankra commented Mar 29, 2023

This is the difference between like 60 deps getting glommed into axoproject, and therefore cargo-dist.

ashleygwilliams
ashleygwilliams reviewed Mar 30, 2023
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i'm interested in the irrefutable let patterns bit, otherwise looks good to me :)

tests/local_copy.rs Show resolved Hide resolved
ashleygwilliams
ashleygwilliams approved these changes Mar 30, 2023
View reviewed changes
Copy link
Member

@ashleygwilliams ashleygwilliams left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wooo

@ashleygwilliams ashleygwilliams added this to the 0.1.0 milestone Mar 30, 2023
@Gankra Gankra merged commit 87d7315 into main Mar 30, 2023
@mistydemeo mistydemeo deleted the cfg-remote branch September 14, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ashleygwilliams ashleygwilliams ashleygwilliams approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.1.0
Development

Successfully merging this pull request may close these issues.
2 participants
@Gankra @ashleygwilliams