Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: separate compression into cargo features #47

Merged
merged 4 commits into from
May 4, 2023

Conversation

shadows-withal
Copy link
Contributor

This PR hides compression features behind a feature flag (compression), which itself can be broken up into more granular features (compression-tar and compression-zip).

@shadows-withal shadows-withal force-pushed the feat/compression-features branch 2 times, most recently from 5f61bae to 86e0aa4 Compare May 2, 2023 10:49
Copy link
Contributor

@Gankra Gankra left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

huh I had forgotten that zstd and gzip were in the same crate

we could theoretically make this more fine-grain so you could turn off xz seperately but honestly this is already solid. only change is cleaning up the cfgs

src/compression.rs Outdated Show resolved Hide resolved
src/compression.rs Outdated Show resolved Hide resolved
src/lib.rs Outdated Show resolved Hide resolved
@shadows-withal shadows-withal requested a review from Gankra May 4, 2023 12:50
@shadows-withal shadows-withal merged commit 8ae6219 into main May 4, 2023
@mistydemeo mistydemeo deleted the feat/compression-features branch September 14, 2023 22:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants